delicious_cron() hook doesn't actually do anything

running "SELECT user, lastupdate, lastcode
FROM delicious_user" I get one row returned..

user: willwade
lastupdate:
lastcode: 0

by the way my cron script is stuck into cron to run every 10 minutes - not sure if that matters..

thanks

will

Ok I know where the problem is occuring.. why is another matter:

around line 241 of delicious.module:

  while ($u = db_fetch_object($result)) {

it never executes that line properly - or at least it does and it always returns nothing..

if you change it to (this is brutal hacking - I cant work out drupals logic..)

  while ($u = db_fetch_array($result)) {

the _delicious_update_user($u) does get executed but of course it errors out in that function because it is expecting the object rather than the array..
what to do from here is where I got lost.. back to you mr merlinofchaos :)

debugging is a nightmare in drupal isnt it??!

hth
w

No probs on not working on it - funnily enough the reason why Im looking at it this afternoon is because I have a cold..(and can't stand to think of the work I am meant to be doing..!!)

outputs as expected:

class stdClass {
  var $uid = '1';
  var $name = 'willwade';
  var $user = 'willwade';
  var $pass = '*******';
  var $lastupdate = '';
  var $lastcode = '0';
}

pass of course starred out. That would be just plain silly :)

I had a thought - is it because there is only 1 row returned?? I wouldn't of thought so..

... and I meant to say..
it all works in the loop..

looking further is being called
where it is erroring out is around 655

if ($resp->code != 200)
  {
   echo "chheeeeese grommit! the resp code is: ".$resp->code;
    db_query("UPDATE {delicious_user} SET lastcode = $resp->code WHERE uid=$user->uid");
    return 0;
  }

and it prints:

class stdClass {
  var $uid = '1';
  var $name = 'willwade';
  var $user = 'willwade';
  var $pass = 'narfzoik';
  var $lastupdate = '';
  var $lastcode = '0';
}
chheeeeese grommit! the resp code is: 0

0 eh?? mean anything to you?

im replying to quick:

$resp = _delicious_get_page(DELICIOUS_UPDATE_URL, $user->user, $user->pass);
     echo "chheeeeese wallace! the resp code is". $resp->code."\n\n";

  if (!$resp->code || is_string($resp->code))
	  $resp->code = 0;
  if ($resp->code != 200)
  {
     echo "chheeeeese grommit! the resp code is". $resp->code.'';

    db_query("UPDATE {delicious_user} SET lastcode = $resp->code WHERE uid=$user->uid");
    return 0;
  }

chheeeeese wallace! the resp code is 200

chheeeeese grommit! the resp code is 0

so although it was 200 its getting changed to 0

commenting out

//if (!$resp->code || is_string($resp->code))
//	  $resp->code = 0;

allows the cron to continue. yay.
Intrestingly (and perhaps this should be logged as a new bug) I get a mysql error

user error: Duplicate entry '8-digby' for key 1
query: INSERT INTO delicious_tag (lid, uid, name, synced) VALUES (8, 1, 'digby', 1) in /includes/database.mysql.inc on line 66.

so 1 down, 1 new one to go...

:)

w

(im such a muppet re: pass)
this fixes it by the way:

  if (!$resp->code || !is_numeric($resp->code)){ $resp->code = 0; }

of course the other bug is nothing major - the script carries on as normal..
good teamwork :)
w