Captcha token invalid

Thanks for your feedback. I will look into getting the module to work with captcha forms. Check back here for updates.

Changed it back. They are very slightly different.
When filing bugs, try your best to always test the latest dev version, in the case that your bug was addressed since the major release.

In this particular case, you did it right though.

Soelver,

This has been fixed for captcha-6.x-1.0-rc2 in ajax-6.x-1.x-dev. There is now a "patches/captcha" directory which contains a set of patches that you must apply in order for Ajax forms to work with Captcha.

If interested, you can also see that I have submitted these patches to the module author here: http://drupal.org/node/334377. Perhaps you can vote these up so he will commit them to Captcha core.

Soelver,

I forgot to mention that you will need to wait up to 12 hours for the 6.x-1.x-dev package to update.

You can read more about applying patches here: http://drupal.org/node/60108.

To vote the patch up, just leave a comment and say that you support the patch and want to see it in the core module.

Thanks

Hi,

I've tried to apply your patch on both the latest dev and the latest stable release of CAPTCHA 6.x and both don't work. I still get exactly the same error as described above. I've tried disabling and reenabling both products, that didn't help either. Is there some further step I need to do after having applied the patch?

Thanks,

Martin

soelver, you can pretty much apply the patch manually.. there are 3 patch files with names corresponding to real files in the captcha/ module folder..

open the .patch file, it will have some lines with a "+" in them.. these lines you need to add to your captcha.module file.. to know the correct position, you can either check the context (lines before the "+"-marked lines) or see line number specified at the beginning of each block around the "+"-lines.. Oh and obviously the "-" lines are the ones you need to remove..

Now I've done that, but I suppose one needs to reload the module somehow or there is still something missing, coz it doesnt' fix the problem :(

Arski,

Did the patches apply correctly?
Did you try clearing the cache?
What is the exact version of Captcha that you are using?
Which type of Captcha are you using (image, math, text, etc)?
Did you enable the forms in the Ajax Forms Settings page?

Changing status

Hi, patches seem to have applied without any errors.

Tried clearing cache, reinstalling, pretty much everything, yes.

Using latest dev version of captcha, which, according to the site, should be "6.x-1.x-dev 2008-Nov-21"
but captcha.module says "// $Id: captcha.module,v 1.58.2.9 2008/08/30 01:20:18 soxofaan Exp $"

Also tried the latest stable release of captcha.

Did most test with the math captcha, but also tried others, same result.

Yes, enabled the forms (tried different forms as well).

My assumption is in the captcha_captcha function.. there the patch makes sure, that the same query is displayed over and over again.. but the "answer" is generated anew, isn't it? To test and confirm this I did the following:

1. click on submit without entering any captcha solution -> "captcha field is required" message
2. submit with correct solution -> "captcha wrong" message
3. keep trying to submit with the same results -> after some 20-30 clicks the solution was accepted, meaning that the module has accidentally generated a query with the same answer as in the first form.. meaning that the $answer is being recomputed, when it shouldn't.

Hope this helps,

Martin

Arski, Soelver,

The Captcha module has a lot of confusing stuff in it. I guess I will have to dig into that patch again. This may take a few weeks for me to finish to be honest, but I will get it fixed. If you guys want to dig in and try to fix it as well, I would be extremely appreciative.

For now, leaving this bug open.

well.. I've found a fix that works.. however might not be perfect..

unset($_SESSION['captcha'][$form_id][$captcha_token]);

See that line unsets the solution from the session and the way AJAX loads the page, it doesn't go to pre_render to set it again.. (or set a new one as it would without ajax..).. so if you comment out that page, the ajaxified form works like a charm..

The comment before that lines says that it's made to prevent spammers sending a form request without actually posting.. but in a way this is what ajax is doing here, so.. any better ideas?

One thing I would really love to have tho is the captcha ajax-removed when it's entered correctly.. one can't access the session from js, but one can check if one of the error fields is "captcha_content".. I was able to do that in your ajax code, but I couldn't really figure out how the elements are accessed and how it would be possible to make the captcha disappear :o

Hope you can help with this.. thanks a lot!

Arski,

I will look into that Session variable. Thanks.

I have made some fixes to the captcha handling. The patches remain the same, but the module code has changed. As of now, captcha-6.x-1.0-rc2 on Drupal 6.6 with zzzz_ajax-6.x-1.4 seems to be working quite well.

Let me know if you are having any other problems.

Thanks

Hi,

I see you made the CAPTCHA renew itself on every missing/wrong submission. Works like a charm.

However there is still one ugly "feature": if I submit the correct captcha but have an error somewhere else in the form, i.e. the form is displayed again, I also get the captcha field again with a new task.. it doesn't matter if I enter something in there or if it's correct now (since the setting on my site is to store a cookie once the user has submitted a captcha correct once), but this is really distracting and just not nice :)

Could you maybe take a look at some way of making the captcha field disappear altogether if the site is configured to not show it again if it has been submitted correctly once.

Thanks again for the patch!

Martin

Arski,

Could you open a new bug for this?

Thanks,
brendon

dsfvdsfvdsgfdsgfdsgf