I have attach a patch to the latest release of yui to bring it in line with the Drupal coding standards.

Also, this patch suggests simplified signatures for the add_css and add_js functions.

CommentFileSizeAuthor
yui.module.patch5.55 KBwulff

Comments

bakyildiz’s picture

bakyildiz commented

I see that the add_css and add_js functions signutures has 2 parameters. But the other yui modules are using this signatures with 3 parameters. This will cause problem. By the way is it possible to work with the lates release or with the development snapshot?

wulff’s picture

wulff commented
Version: 6.x-1.1-2 » 6.x-1.1-beta3

I chose the wrong version when creating the issue. This is a patch against 6.x-1.1-beta3 (v 1.9.2.2).

The change to the _add_* signatures is mainly meant to make code using the yui.module more readable, since a currently unused and am unneeded argument can be removed or made optional. I realise that it will take some work to bring the other yui_* modules in line.

bakyildiz’s picture

bakyildiz commented
Assigned: Unassigned » bakyildiz
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.