National characters display with error

i haven't tested on an international system. are characters like that normally allowed in URL paths?

i noticed in your screenshot that the thumbnails aren't displaying as well. were the pictures linked correctly and thumbnails displayed in the older version? (which older version, btw?)

there are problems with having international characters in the URL path, and all folders/files are stored by path. but i dont have an international system, so i don't really know how things behave.

UPDATE: ok, i've been messing around with mb_convert_encoding (if you recall, we added this in because some ppl reported special characters weren't being saved to the database). but i guess that's causing other problems. i'll post up a new test version soon. what encoding are you using btw?

hi lomz:

try the attached version. you may want to uninstall the old version first, as i took out the option for renaming files so uninstalling will delete the variable.

this version converts between ISO-8859-1 and UTF-8 encoding. it works for me for special characters in the path, filename, and EXIF data.

not sure how nicely that plays with an international system, so post back and let us know!

:)

cheers,

-nick

what encoding/system are you using?

i mean, what is the default encoding of your location. the code i posted above converts between UTF-8 and ISO-8859-1 (my encoding) to process the paths, and it works fine for me b/c well, i'm in ISO-8859-1 location ...

can you execute the php code in a page and tell me what you get for output?

<?php
  var_dump(iconv_get_encoding('all'));
?>

for example, i get:

array(3) { 
  ["input_encoding"]=>  string(10) "ISO-8859-1" 
  ["output_encoding"]=>  string(10) "ISO-8859-1" 
  ["internal_encoding"]=>  string(10) "ISO-8859-1" 
} 

UPDATE:

add this line in fast_gallery.module, line 757 and let me know if that works any better:

      $caption = mb_convert_encoding($caption, 'UTF-8');

add it after:

      // Now grab the directory that this folder should link to
      $current_folder_ar = arg();
      for ($i = 0; $i < _fast_gallery_get_alias_count(); ++$i)
        array_shift($current_folder_ar);
      $current_folder_ar[] = $folder_path_elt;
      $folder_link = implode('/', $current_folder_ar);

      $folder_link = str_replace(' ', '_', $folder_link);

      // Grab the folder name to label it, as the caption
      $folder_name = end(explode('/', $value->folder));
      $caption = str_replace('_', ' ', $folder_name);

      // ****PUT THAT LINE HERE

Confirm error. This used to work (3.1beta1). I have some photo's with ñ, which were not a problem before.

Also, I get these errors on the general settings page for fast gallery (not every time, but it seems after changing a setting and saving, or something like that):

# warning: exif_read_data() [function.exif-read-data]: Unable to open file in /sites/all/modules/fast_gallery/fast_gallery.class.php on line 316.
# warning: filemtime() [function.filemtime]: stat failed for album/2008/Piñani.jpg in /sites/all/modules/fast_gallery/fast_gallery.class.php on line 323.

Where "ñ" in the filename would be an "ñ".

ok, regressing to some old code. looks like mb_convert_encoding() can't be used in the file paths, only works on some systems but not others. :P

try this, let me know if special characters still show up in the descriptions/captions.

PS: sorry for all this back-and-forth testing. i don't have a setup where i can simulate international servers/systems.

ok, that's good to hear :). now if i can just find a way to get international characters working on my setup without breaking it for everybody else again .....

do the national characters still show up in the image captions in the last version i posted?

i changed mb_convert_encoding() to utf8_encode() and utf8_decode().

can anybody test this version (with national characters) on a non-u.s. server? also can you report on whether links are working correctly to pictures and to folders? also custom folder thumbnails, and breadcrumb links?

if the names aren't right, try adding this line to fast_gallery.module on line 784:

...
      // Grab the folder name to label it, as the caption
      $folder_name = end($folder_name_ar);
      $caption = $folder_name;

      // THIS LINE
     $caption = utf8_decode($caption);
...

thx .. if this testing gets too long-winded, i might have to just postpone this feature (support for national characters) to not work on all systems.

ok, new update. i hope we get to the bottom of this :P thanks for all the testing work, lomz.

i don't expect custom folder thumbnails to work yet, with national chars.

totally unrelated note, added 2 more options for Image Caption selection (Copyright and Artist) by request #293857: Image caption not working in thumbnails

another update. i tried tracking down the problem, and what i'm guessing right now is that my webhost server doesn't encode to UTF-8 or decode from UTF-8 when accessing the database, because it probably normally doesn't expect national characters.

sooooo, i've included a new setting on the Advanced settings page to toggle that UTF-8 conversion. if one way doesn't work, toggle it off/on and see if that works.

i also worked on getting it to work when national characters are in the gallery path, which seems like it fixed the custom folder thumbnail problem.

also added the option for including images on pages other than the current one (#332873: Pictures on picturepage 2 doesnt show). it seems to work with Thickbox as well

lemme know how this version goes, and i'll start updating the documentation. thx!

PS: a quick side note, remember to refresh your browser, b/c there are changes to the CSS. and in firefox, i had to clear the cache/private data. and again, it's better to uninstall everything in old version first.

thanx! :)

whoops, good catch. i was wondering where else i forgot to fix.

one more version, there was some bug in the random image block too that i fixed.

updated documentation.

i also removed some blocks that looked like they were unused code. so let me know if i removed anything important >_<

the test cases i was running into for the special characters was when Clean URLs were toggled on or off. it does some weird things to the links, so that's what i've been testing. lemme know how this version goes ..... other test cases to test might be, with Hierarchy on/off, Imagecache on/off.

-nick

can anybody else confirm this, so I get check it in.
I think we should make a stable version soon.

Created a Beta2 Version.

Sorry, I still get titles like this: '?????? ????'
I'm using win xp with windows-1251 encoding

did you try toggling the UTF-8 caption conversion on the Advanced settings page?

OK, it seems that exif_read_data doesn't work properly on my system

UPD: Now it works fine, but there is no utf8_decode for image captions, so it put it by myself.
Thanx =)