Drupal 6 Integration

Hi Omar,
Thanks for this - I'm testing out this patched version of RSVP on Drupal 6.
So far, I only have one issue (because it prevented me from going any farther), and one other observation.

Issue:
* I've added a CCK node type called 'event' just for fun
* I've added a date field (tried with both 'date' and 'datetime' - does it matter which? the README says datetime, but I usually prefer date because I sometimes allow only the year and month to be selected, and KarenS suggests date for this purpose - see this issue for ref #269813: Date vs. Datetime)
* I applied the proper permissions ('rsvp on events' to authenticated user, and all perms to site admin).
* I made an association based on date (also tried with datetime)
* The problem is, even though my event is in the future, I'm getting the following message:

This event has expired, invitations can only be sent to events
that have not expired yet.

You don't have created any RSVPs.

* I can't test any further yet because this isue doesn't allow me to rsvp.

Another observation:
* After applying the patch, there are two instances of rsvp_views (one in the contrib folder and the other in the rsvp directory root) - and neither are compatible with D6 core. I assume this isn't waht was intended -- but I can't make out from the patch what was the intention exactly -- was it to delete the contrib folder and add the rsvp_views.info & rsvp_views.module files into the rsvp module root directory? If so, I can try to add the patched lines manually to those for testing. (but can't do much anyway until the issue above is fixed).

I'm ready to test the next patch whenever you've got one :)
Scott

Just stopping by and noticed this...

+function rsvp_views_api() {
+  return array(
+    'api' => 2,
+  );

should be the following if you want views includes in the module's root directory. Otherwise throw them in /includes.

+function rsvp_views_api() {
+  return array(
+    'api' => 2,
+    'path' => drupal_get_path('module','og_rsvp'),
+  );

hi Ulf,
I tried this patch, and it didn't delete the contrib folder - it still creates another instance of rsvp_views.info & rsvp_views.module in the module root. It sounds like you intended to get rid of entirely, so I removed the contrib folder and those two files from the root as well.
I uninstalled the RSVP date connector module, and tested again with the newly patched version. Then followed the same steps as above...

But I'm still not able RSVP (?). Same error as above This event has expired....

If it works for you, it seems possible the patch didn't work in other places as well? I'm attaching the module after trying to apply the patch (and after deleting the rsvp_views files mentioned above. Can you try this and see if you can reproduce my error?

If so, could you please attach a patched version since it would seem there are problems with the patch?

Thanks :) Scott

Aha... - Ulf, the problem was in my datefield... I had (to date) set to 'never' (rather than optional or required) - to allow only a single starting date and time.

So I now set it to optional (so I can choose to have only a start date if I want), and now I can RSVP! So I did not apply your test module, because it looks like we found the problem. Personally this is fine for me, because I will need a (to date) for my application anyway.

This issue may be a fringe case. however because 'never' is a (to date) configuration option for the date module, we might want to check whether the datefield has this option available before checking if the end date is earlier then the current date? Or maybe we just need to add this note to the README so people know to enable the end date.

I'll continue to test -- but this at least clears up this particular issue -- Thanks ;)

Oops, I spoke too soon...

I created an RSVP using the above case - but then got these errors:

    * warning: array_merge_recursive() [function.array-merge-recursive]: Argument #2 is not an array in /Applications/MAMP/htdocs/test/sites/all/modules/rsvp/rsvp.module on line 1068.
    * warning: array_merge_recursive() [function.array-merge-recursive]: Argument #1 is not an array in /Applications/MAMP/htdocs/test/sites/all/modules/rsvp/rsvp.module on line 1071.
    * warning: array_merge_recursive() [function.array-merge-recursive]: Argument #1 is not an array in /Applications/MAMP/htdocs/test/sites/all/modules/rsvp/rsvp.module on line 1075.
    * warning: array_merge_recursive() [function.array-merge-recursive]: Argument #1 is not an array in /Applications/MAMP/htdocs/test/sites/all/modules/rsvp/rsvp.module on line 1078.

Then I went back to my event - and the (to date) was completed to match the start date & time.
I thought - maybe datefield doesn't save this automatically, but only completes if you go back to edit the node. So I saved the node just for kicks... (so start & end date/times are exactly the same, rather than leaving end date empty).
It now looks like the RSVP is ok -- or at least I'm not getting errors anymore :)
we should check whether to date is an array, and if not, add the data from the from date?

Update:
This is happening even with an ending date.

Hmm, I added attached test in #8 as the new rsvp_dateconnector.module (and renamed the existing one to 'rsvp_dateconnector.moduleOLD'). I also cleared the cache just for fun... (didnt' run updates, because seems this isn't necessary?).

Next I deleted the existing association, and created a new association just to be safe.

I then tried to create an RSVP with an event that does have a start & end date / time set.
However, I get the same error (see attached Picture 2). I can not add or manage attendees under this tab, just see the error there.

But if I follow the breadcrumb trail back, I do see that an RSVP has been created (see Picture 3).

just staring to follow this now and have a couple of quick questions:

i'd love to help test this - will there be an experimental d6 dev release put up anytime soon for those of us clueless about patching?

the module page says event module is still required, but this d6 version appears to support datecck - what exactly are the requirements if using rsvp on d6 *without* event module? will i still need simplenews to process?

has anybody tested on d6 with date cck where the field is unlimited? meaning: event custom content type with date fields allows one event to be added on multiple times/days in one node - but with a signup reflecting 'each time/date' as an option?

I've been using your patch with Drupal 6, and it's mostly fine.

I've come across one issue: If you only enable 'RSVP', and don't enable any of the other 'RSVP' modules, you get the following error on all non-admin pages:

Fatal error: Call to a member function is_event_enabled() on a non-object in /home/eclaninf/public_html/modules/rsvp/rsvp.module on line 3297

Keep up the good work!

+1

Hi, is there going to be a full release of RSVP for Drupal 6? This is a great module.
Thanks

Great job ulf1 and sorry everyone for being away that long.

I have successfully patched HEAD with #14.

I will create a branch for D6 so we can all test the module.

D6 branch created and module page updated.

Please wait until d.o cron updates the list of available versions of the module.