Closed (fixed)
Project:
Real Name
Version:
6.x-1.1-rc1
Component:
Miscellaneous
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
5 Nov 2008 at 10:04 UTC
Updated:
27 Oct 2009 at 19:06 UTC
hi, i would like to help maintain the realname module as i find it really useful.
i do not have a cvs account, i will have to apply for one sometime :)
i have ported the uc_paygate module (http://drupal.org/project/uc_paygate) - you will see a credit to me on the project page.
J
Comments
Comment #1
nancydruYes, you would need a CVS account. Can you maintain both 5.x and 6.x?
Comment #2
theamoeba commentedill apply for a cvs account and i will use this task as a reference. i am only familiar with 6.x unfortunatly.
J
Comment #3
nancydruI'd really like to have someone who can do both active branches.
Comment #4
theamoeba commentedok
Comment #5
nancydruYou are still very welcome to submit patches.
Comment #6
theamoeba commentedcool - ill do that :)
Comment #7
nancydruComment #8
nancydruComment #9
guillaumeduveauHi NancyDru,
I'm fine with helping you maintain Realname on both 6.x and 5.x. However as I see it, 5.x would stay at 5.x-1.x with only bugfixes, and new features would be implemented in 6.x-2.x. Let me know what you think about it !
Guix
Comment #10
guillaumeduveauActivating... And I do have a CVS account, BTW.
Comment #11
nancydruThank you. My schedule is quite full these days.
The auto completion part of 5.x is not in what I would consider a final state. I'd like that, at least, finished. I would have to look over other issues to see if I think they should be done, but I suspect 5.x is pretty much at its end.
If you don't mind, I would like to see a few patches before I grant you access. If you don't already have it, we need to run Coder pretty much every time. And I would like to see the Translation template extractor run every few commits, and definitely before a release.
Comment #12
guillaumeduveauHere are some patches around Realnames I submitted : #502708: Realnames not rebuilt, #369334: Realname for Privatemsg autocomplete, and a new module : #380460: CCK User Reference autocompletion integration with Realnames
I've stopped running Coder when submitting patches, because it makes it more difficult for the maintainers to see what the patch changes. But on my own custom modules and for the one I'm the maintainer, I always run it. It helps getting used to writing better code when submitting patches, too ;)
For PotX, I run the command-line version. OK to run it with every release and a little more, when adding a lot of new strings.
Now I'm not saying I'm qualified to fix all the bugs, but I can at least devote some time trying to do it and reviewing others patches carefully. For the feature requests, I can devote time proportionnally to my interest in the feature.
Well now you see for my maintainer request, I won't be offended if you prefer to decline :) I'm probably not the maintainer of your dreams but I can sure help.
Autocompletion
For the autocompletion, I don't have any clear idea yet about how a generic solution could be used, even in 6.x.
See #369334: Realname for Privatemsg autocomplete for instance, your generic autocomplete function realname_ajax_autocomplete_user() can't be used because the feature needs to check privatemsg_allow in the DB. But maybe we could add an array as an optional variable, like
and pass the function additional DB commands : JOIN with other tables, WHERE, ... Just thinking out loud, I didn't try.
Also there's the problem of Realnames not being unique, and we still have to pass the user name in a lot of cases, and my solution was to inject 'Realname (user name)' in the ajax results and then extract only the user name to pass it to contrib modules. I don't know if it's always possible. Note that we could use Realname (UID) (or any other syntax with both) instead of Realname (user name), but since Realname == user name if the Realnames profile fields are empty, I chose the first.
I don't see anything to be done about this. There's a relevant issue : #125231: Enhance autocomplete feature which needs reflexion beyond my knowledge of Drupal.
Finally, I therefore see a limited interest in a generic autocomplete function, since even if we could write one that could be customized with variables, half of the time we will have to intercept the form validation of the contrib modules, when possible (not always in 6.x) and process the values. So customization for contrib modules will often be necessary anyway. But we can try to have a more flexible autocomplete function !
Comment #13
nancydru@guix and theamoeba: You have CVS access now.
Comment #14
nancydruComment #15
guillaumeduveauThanks NancyDru, sorry I didn't see that before ! Good work on 6.x.1.3 !
Comment #16
nancydruMy time is extremely limited for a while; feel free to make fixes.