There is something wrong with the implementation of drupal_get_destination in this module as accessed from the translation overview tab.

I think it has to do with drupal_get_destination being called incorrectly because the function returns destination=url already, but the translation_overview code adds an extra destination=. So URLS look like destination=destination%39node%39123 which is wrong.

Comments

drewish’s picture

drewish commented

which version are you using? there aren't any tabs in the 2.x version.

westwesterson’s picture

westwesterson commented
Version: 6.x-2.x-dev » 6.x-2.0-beta2

beta 2

drewish’s picture

drewish commented

then where are you seeing the links?

westwesterson’s picture

westwesterson commented

http://example.com/node/536/translate

The links the go to the node edit pages from the translate page.

drewish’s picture

drewish commented

oh, gotcha, i understand what you mean now--urls are always helpful ;)

but that said, i'm not seeing the behavior you're describing... i'm seeing links like:

http://nm/?q=en/node/add/image&destination=node/2264/translate&translation=2264&language=de
http://nm/en/node/add/image?destination=node/2264/translate&translation=2264&language=de

is there a particular way that you're getting to the node's translation tab?

westwesterson’s picture

westwesterson commented

no, nothing in particular...

full url looks something like this:
http://nm/en/node/738/edit?0=destination=destination%3Dnode%252F777%252F...

clean urls turned on
the 0 is weird...

drewish’s picture

drewish commented

i'm not really sure what to tell you... do you have any other modules installed that would be rewriting links? if you'd like to message me an account and password i can login and take a look.

drewish’s picture

drewish commented
Status: Active » Postponed (maintainer needs more info)
drewish’s picture

drewish commented
Status: Postponed (maintainer needs more info) » Closed (fixed)

i'm assuming you got it figured out due to the lack of feedback.

ru.meta’s picture

ru.meta commented

I also have links like

node/540/edit?query=destination%3Dadmin%252Fcontent%252Ftranslation_overview_manage

My version is 6.x-2.2
I found that if I replace

$link['options']['query'] = array('destination' => drupal_get_destination());

with

$link['options']['query'] = drupal_get_destination();

Links work well

ru.meta’s picture

ru.meta commented
Version: 6.x-2.0-beta2 » 6.x-2.2
Status: Closed (fixed) » Needs review
drewish’s picture

drewish commented
Status: Needs review » Fixed

sorry this was committed back on September 21, 2009.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.