mapi_filter.module looks beautifull, very generic; Maybe you should move this to a seperate module so it becomes something like inline.module 2 is supposed to become (generic filter macro module). Call it filter_macro.module or something like that.

You only used mapi_files_exists() which can be easily moved to implementations of hook_mapi_filter().

Comments

rhys’s picture

rhys commented

I'm not quite sure how to go about doing what you are suggesting.
Do you mean to rename the hooks from mapi_filter to filter_macro?
Change the module into filter_macro, remove the mapi_file_exists into the hook_filter_macro or something?

The [tag:settings:profile] is very mapi_filter_specific, so I'm not quite sure what I would also need to do to make this more generic.

rhys’s picture

rhys commented
Status: Active » Closed (fixed)

The filter_macros module now exists, but I'm not sure for how long. I'm withdrawing from the drupal community due to work concerns.