Why is it that the voting limits have 3 digits? Sometimes I want to vote for something more than 999 times. On popular items some of my votes could reach 5 or concievably 6 digits. I don't see a reason for the limit at all. Please expand on it. Thanks.

Comments

mercmobily’s picture

Hi,

Please show me a web site with more than 999 votes.

Merc.

Flying Drupalist’s picture

Hi Merc, digg regularily goes over 999 votes. Some of my more popular posts have over a hundred thousand views, if I deploy EVF on their comments I expect the top comments to get much more than 999 votes one way or another. But the point is, I'm using voting to differentiate and rank content, if there is a 999 limit then that wouldn't work for the highest ranked stuff.

If you use time based items like digg does, then 5 or 6 digit items are rare. But that artificially limits the ways in which this module can be used. If you look at any content or review site, most of them have more than 999 voters. IMDB for example.

Thanks.

mercmobily’s picture

Hi,

"Please show me a web site [that uses Drigg and that has a story] with more than 999 votes."

...where is it? :-D

Merc.

Flying Drupalist’s picture

Hi Merc, I don't use drigg. I don't understand what you are trying to say, I don't know any such sites. But if I'm to implement EVF I need more than 3 digits. I explained why in my previous comment. Like I said, I'm not using EVF like Digg or Drigg uses it, to promote news items, I'm using it to rate and recommend content (that has no time limitation, e.g, Shakespeare will never be old news). Nodes (and comments too actually) easily, easily, pass the 3 digit mark.

mercmobily’s picture

Hi,

Ah! Sorry. I have ever only used EVF with Drigg, and forget that people actually use it outside it...

So, the question is: can you point out *one* single site that uses EVF with more that 900 votes on a single node?

My point is that we need to keep development efforts on realistic goals. If there are 0 sites out there that need it, then I would be spending devel time on something that nobody actually needs. Somebody who "might potentially need it in the future, maybe, who knows" is not really enough.

If there is exactly 1 site out there, then a patch is most welcome.

If it's a common case scenario, then devel time is justified...

Merc.

Flying Drupalist’s picture

Hi, thank you for your explaination. I apologize for not having a patch, I read the docs but I can't get Eclipse to work correctly... Anyway, I really appreciate all the work you're doing and I know you have a lot on your hand. I posted this issue because I thought it was strange that there was such a limit on the number of votes. My vbulletin site, which has threads over 200 pages, is moving to drupal, and I want everything to work correctly before I do. But I understand if you want someone to second the request or something. But the devel time to make this edit would be very small, there are only 4 integers to make larger. Thanks for listening.

mercmobily’s picture

Hi,

OK...
There is no hard-coded limit to EVF to three digits.
Can you tell me where you saw the limit precisely? I think it might just be CSS... I might be missing something :-D

Bye!

Merc.

Flying Drupalist’s picture

Hi, I think it's the max length here, which I set to 15. I think it starts at line 231 in extra_voting_forms.module

$form['voting_range']['extra_voting_forms_range_users_plus_n'] = array(
'#type' => 'textfield',
'#title' => t('POSITIVE karma points for normal users - NODES'),
'#size' => 15,
'#maxlength' => 15,
'#required' => TRUE,
'#default_value' => variable_get('extra_voting_forms_range_users_plus_n', 1),
);

$form['voting_range']['extra_voting_forms_range_users_minus_n'] = array(
'#type' => 'textfield',
'#title' => t('NEGATIVE karma points for normal users - NODES'),
'#size' => 15,
'#maxlength' => 15,
'#required' => TRUE,
'#default_value' => variable_get('extra_voting_forms_range_users_minus_n', 3),
);

$form['voting_range']['extra_voting_forms_range_users_plus_c'] = array(
'#type' => 'textfield',
'#title' => t('POSITIVE karma points for normal users - COMMENTS'),
'#size' => 15,
'#maxlength' => 15,
'#required' => TRUE,
'#default_value' => variable_get('extra_voting_forms_range_users_plus_c', 1),
);

$form['voting_range']['extra_voting_forms_range_users_minus_c'] = array(
'#type' => 'textfield',
'#title' => t('NEGATIVE karma points for normal users - COMMENTS'),
'#size' => 15,
'#maxlength' => 15,
'#required' => TRUE,
'#default_value' => variable_get('extra_voting_forms_range_users_minus_c', 1),
);

?>

mercmobily’s picture

Hi,

I am not sure I am following you...
Those are just the config input forms for the module. And their limit is 15, not 3.

Am I missing something?

My question is: where do you see that EVF will puke with more than 999 votes?

Merc.

Flying Drupalist’s picture

Sorry for being unclear merc. It WAS 3, I set them to 15 on my setup, and didn't bother to change them back before i pasted it here. But you had set the voting limit field to a 3 max length, effectively limiting the number of votes to 999.

Thanks.

mercmobily’s picture

Hi,

I am 99.5% sure you are misunderstanding the configuration here.
Those values determine how much karma is given when a node or comment is voted up or down. The range is not the total range, but the "select" button range.

Are you sure you are using this module right?

Merc.

Flying Drupalist’s picture

Hi, when I was voting earlier, if the fields were lower than the voting range I got the an error... which to the best of my memory was something along the lines of: Voting outside of voting limit, vote not counted, etc. But you know, I went back and lowered the number but is not able to reproduce this message.

Maybe I'm showing you the wrong fields. What I actually did was ctrl-replace all maxlength 3 to maxlength 15. But doesn't "Up/Down voting values" control how much karma is given when something is voted upon and "Allowed voting range dictate" the max values?

Sorry, you're probably right that I'm misunderstanding something.

mercmobily’s picture

Hi,

Those ranges control how much karma can be given with a *single* vote. They have _nothing_ to do with how much total karma a node/comment can receive or display.

I don't believe there is such a limitation in the module. Please show me where the limitation is -- if you can't, I'll close this issue.

Bye!

Merc.

Flying Drupalist’s picture

Status: Active » Closed (fixed)

Hi Merc, there doesn't seem to be a hardcoded limit. But I don't understand why I got that error. Thanks, and sorry for the non-issue!

mercmobily’s picture

Hi,

Not sure which error you're talking about... but all good :D

Merc.