Closed (fixed)
Project:
Extra Voting Forms
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
6 Nov 2008 at 19:45 UTC
Updated:
15 May 2009 at 13:14 UTC
Hi, with both fivestar and EVF enabled on one node, if I vote EVF, and then vote 5 star, the EVF score will be deleted. At first I thought this was a voting api thing and I made an issue there, but then I noticed that voting EVF doesn't do anything to five star, 5star's score won't be overwritten or whatnot by EVF. This is a big problem for me, thanks for listening. :)
Comments
Comment #1
mercmobily commentedHi,
Both Fivestar and EVF use "votingAPI". So, they are likely to both change the same items in the database.
I am surprised 5star doesn't get affected -- are you sure that's the case?
Can you please pick a specific node, and show the content of the VotingAPI table for that node 1) With no vote 2) With one vote by EVF 2) With a subsedquential vote from 5stars 3) Again with a vote from EVF ...? For each point, please tell us what you see after a reload.
Bye,
Merc.
Comment #2
Flying Drupalist commentedOf course. I did this test multiple times before posting this issue. Fivestar is not affected by EVF.
Comment #3
mercmobily commentedHi,
"Can you please pick a specific node, and show the content of the VotingAPI table for that node 1) With no vote 2) With one vote by EVF 2) With a subsedquential vote from 5stars 3) Again with a vote from EVF ...? For each point, please tell us what you see after a reload."
Merc.
Comment #4
Flying Drupalist commentedHi Merc,
I pick a node, vote with EVF. The SUM cell is 1, % cell is 0. I vote with 5 star, the % cell is 50% (5 stars out of 10), the SUM table is 0. I vote down and then up again with EVF, the SUM cell is 1, the % cell is 50%.
Like you, I thought it was really strange that things work this way, that's why I initially created an issue in VotingAPI. The SUM and % cells (views), only take into account EVF and Fivestar respectively. Testing with many more users find that EVF doesn't do anything to the % cell, even though I thought it would. What I've done in views is set the two to two seperate relationships, though that's just views and I don't know what actually happens in the database. This test I did multiple times, this is the only way I could've come to my conclusion. If you don't believe me, it's simple to check it out.
Thanks for being patient with me.
Comment #5
mercmobily commentedHi,
No worries at all.
What's going on, is that EVB doesn't actually calculate percentages.
Testing this would imply me setting up views, EVF, 5stars on two different nodes... It's a bit much.
I *think* the problem here is that EVF doesn't do percentages, whereas fivestar does. Plus, fivestar sets the "sum" to 0 (which screws EVF up).
I don't really think there is a clear way to solve this. You are using two different voting forms that deal with data in two different ways... I don't think it's gonna work!
And no, I swear you're not bothering me at all! :-D
Bye,
Merc.
Comment #6
Flying Drupalist commentedThanks! That makes a lot of sense, I'll take this up with Fivestar and see if there's a way for them to not reset SUM. :)
Comment #7
mercmobily commentedHi,
Any news on this one?
Merc.
Comment #8
Flying Drupalist commentedI posted but Fivestar gave no reply. I couldn't wait any further and essentially gave up. I'm using flags now, which doesn't have this problem because it's not voting API. I'm still using EVF for comments. (Though I much prefer EVF in this case to Flags, just that I have no choice.)
AFAIK there's no solution currently to my problem. There probably needs to be some change to the way one or other of the modules store its data for this to work.
Comment #9
mercmobily commentedHi,
Hang on a minute. I am an idiot!
Is there a way to configure 5star so that it stores scores in a different way? That is, something other than "points/vote"?
Right now, EVF is using value type = points, tag = vote. Can you change either one of these for 5stars? (You currently can't for EVF).
Please check *carefully* and let me know!
merc.
Comment #10
Flying Drupalist commentedI don't think so Merc, I looked through the settings but don't see anything of the sort.
Comment #11
mercmobily commentedHi,
I looked at fivestar's code, and I am _pretty_ sure you should be able to change the "tag" from "vote" to something else. I am also 98% sure that will fix the issue.
Please check with the fivestar people or look around fivestar's configuration -- maybe especially for the node type-specific forms, which fivestar alters.
Merc.
Comment #12
Flying Drupalist commentedHi Merc, I'm asking in the Fivestar issue queue. Anyway it's possible there just isn't any UI for that. They might've not seen it fit to create one with such a limited usecase.
Comment #13
mercmobily commentedHi,
That is true... let's see though.
Merc.
Comment #14
Flying Drupalist commentedHi Merc, sorry for the selfish question, but do you think that compatibility issue WILL be fixed? Because if so I will move back from Flags to EVF immediately. EVF suits me much better. I can get around this by telling people to vote Fivestar before EVF as a temporary measure if I know this will eventually work.
Thanks.
Comment #15
mercmobily commentedHi,
What I *can* do, is make sure EVF is configurable so that you set tag ad voting.
That can be done in about 3 hours worth of programng and I could do it after next week.
I want it fixed... how badly do you need it?
Merc
Comment #16
Flying Drupalist commentedHi, what's the difference between tag and vote? Is it just semantics? Would you still be able to give admin bonuses with tag instead of vote?
Anyway, I'm really happy that you're determined to fix it, will move nodes back to EVF right away. I would like this to be working as quickly as possible of course, because my site is already live. But I understand if you have other priorities since you have other great modules to maintain.
Thanks again Merc.
Comment #17
mercmobily commentedHi,
"what's the difference between tag and vote? Is it just semantics? Would you still be able to give admin bonuses with tag instead of vote?"
What's the difference between "car" and "ford"?
"vote" is the default tag for Extra Voting Forms _and_ FiveStars.
Miraploy, are you at all able to put a small bounty towards this? If not, that's cool too.
Merc.
Comment #18
Flying Drupalist commentedThanks for the explaination.
And sorry, I can't offer a bounty, but you have my best wishes and sincerest appreciation.
Comment #19
Flying Drupalist commentedHi Merc, is this still in the pipeline? I'm referring to your very sad (for me) decision to quit drupal.
Comment #20
mercmobily commentedHi,
This is in the pipeline, but it has a rather low priority. There is a lot that needs to be done (to Drigg, FriendList, etc.) and this is not exactly a feature "in demand" -- sorry!
Merc.
Comment #21
Flying Drupalist commentedThis is not needed any more, or at least in this specific matchup. Fivestar added axis in the 2.x version so on the Fivestar side one can set things to not interfere with each other.