Closed (fixed)
Project:
Cache Router
Version:
6.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
6 Nov 2008 at 22:59 UTC
Updated:
10 Jan 2009 at 10:10 UTC
Jump to comment: Most recent file
In last cvs commit eaccelerator backend is BROKEN
here the patch
1) serialize should be called every time for argument when _put
2) Initial statistics - not working except memory usage (another issue latter about stats)
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | eacc_d6.patch | 1.69 KB | andypost |
| #4 | eacc_d6.patch | 2.09 KB | andypost |
| #3 | eacc_d6.patch | 1.26 KB | andypost |
| #1 | eacc.patch | 2.78 KB | andypost |
| eacc.patch | 3.1 KB | andypost |
Comments
Comment #1
andypostForget to set statistics to 0
Comment #2
slantview commentedCommitted in DRUPAL-5, DRUPAL-6--1 and now in DRUPAL-7--1
Comment #3
andypostWhen flush() processes lookup array it checks for a value of key which is broken last commit!
Here the patch: original $expire strores in cache but if $expire is TEMPORARY we use $ttl = 180
So when flush() goes through lookup it cleans only TEMPORARY items - same as original cache.inc
Comment #4
andypostLittle bit optimizations: no need to call $this->key() better make it once and store result in $full_key
Comment #5
slantview commentedOk, fair enough. I posted this in last commit. I'll get it over into D7 and D5 branches as well.
Comment #6
andypostSuppose there's no need to recalculate $this->key($key)
much better to calculate it once and then use it, it brings some performance on often chache_get|set operations
patch against current CVS
Comment #7
slantview commentedThere is negligible performance improvements from this, and it doesn't actually have anything to do with eaccelerator backend fixes from the original post. If you want to file this in a new post I will think about it, but it seems like a waste. String concatenation is not a performance improvement I am too worried about. You are splitting hairs with some of these issues.
Spend some time fixing xcache or something else really useful that we need done so we can get a 1.0 release out. Write some more cache tests, or test on other platforms besides D6 and see if we can get this module more stable in other ways. Maybe consider how to get eaccelerator stats working?
Hope this doesn't come across wrong, but there is a ton more stuff to do before a 1.0 release which I was hoping to have out by the end of the year.