Failed site install should have status 'site disabled'
ac - November 7, 2008 - 04:51
| Project: | Hosting |
| Version: | 5.x-0.2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
Currently when a site fails the status is 'site not installed, site enabled'. The fact that the site is enabled but not installed stops the user from running other tasks like disable site. The status of a failed site install should be 'site not installed, site disabled'.
#1
So the issue here is that the flags are set in the post_install() hook. That hook is (rightly) run only when the site is successfully ran.
My guess is that we could use a rollback hook, similar to what the provision module is doing, to handle those situations.
#2
Actually, thinking aloud here: maybe the site should be marked as disabled as long as it's not installed. The install task currently sets the enable flag on the site, so that wouldn't be a problem....
#3
I think sites should start off as disabled till installed. This would solve this issue.
#4
We just have to fix node_site_insert somewhere...
#5
The problem is we can't initialize them to any of the 'anti' statuses. or weird things happens.
#6
So we talked about this quickly and I feel that yes, HOSTING_STATUS_DISABLED should be an explicitely set value.
#7
Also, 'verify' tasks that lead to 'site not installed yet' should mark the site as 'not installed' so it can be installed again or removed...
#8
I think we should target this for 0.2..
#9
Just a quick note to mention that some work has been done in this direction in the provision module to refactor the error handling and codes, so this should be easier now.
#10
Fixed in #333952
#11
Automatically closed -- issue fixed for 2 weeks with no activity.