please test your module with drupal6-dev (at least once)
and read this issue: #291026: change E_NOTICE to warning and allow selection of error level

# notice: Undefined index: order in navigate\navigate.module on line 483.
# notice: Undefined index: group in navigate\navigate.module on line 647.
# notice: Undefined index: required in navigate\navigate.module on line 651.
# notice: Undefined variable: group_class in navigate\navigate.module on line 657.
# notice: Undefined variable: required in navigate\navigate.module on line 662.
# notice: Undefined index: callback in navigate\navigate.module on line 663.
# notice: Undefined variable: group_input in navigate\navigate.module on line 664.
# notice: Undefined index: type in navigate\navigate.module on line 634.
# notice: Undefined index: 1 in navigate\navigate.module on line 606.
# notice: Undefined index: required in navigate\navigate.module on line 651.
# notice: Undefined variable: required in navigate\navigate.module on line 662.
# notice: Undefined index: callback in navigate\navigate.module on line 663.
# notice: Undefined index: required in navigate\navigate.module on line 651.
# notice: Undefined variable: on_class in navigate\navigate.module on line 657.
# notice: Undefined variable: required in navigate\navigate.module on line 662.
# notice: Undefined index: callback in navigate\navigate.module on line 663.
# notice: Undefined index: clear in navigate\navigate.module on line 710.
# notice: Undefined variable: clear_class in navigate\navigate.module on line 715.
# notice: Undefined index: search_phrase in navigate\navigate.module on line 715.
# notice: Undefined index: name in navigate\navigate.module on line 692.
# notice: Undefined index: wid in navigate\navigate.module on line 846.
# notice: Undefined index: content_type_page in navigate\navigate.module on line 634.
# notice: Undefined index: 1 in navigate\navigate.module on line 606.
# notice: Undefined index: group in navigate\navigate.module on line 647.
# notice: Undefined index: required in navigate\navigate.module on line 651.
# notice: Undefined index: help in navigate\navigate.module on line 689.
# notice: Undefined variable: group_class in navigate\navigate.module on line 657.
# notice: Undefined variable: required in navigate\navigate.module on line 662.
# notice: Undefined index: callback in navigate\navigate.module on line 663.
# notice: Undefined variable: group_input in navigate\navigate.module on line 664.
# notice: Undefined index: content_type_story in navigate\navigate.module on line 634.
# notice: Undefined index: 1 in navigate\navigate.module on line 606.
# notice: Undefined index: group in navigate\navigate.module on line 647.
# notice: Undefined index: required in navigate\navigate.module on line 651.
# notice: Undefined index: help in navigate\navigate.module on line 689.
# notice: Undefined variable: group_class in navigate\navigate.module on line 657.
# notice: Undefined variable: required in navigate\navigate.module on line 662.
# notice: Undefined index: callback in navigate\navigate.module on line 663.
# notice: Undefined variable: group_input in navigate\navigate.module on line 664.
# notice: Undefined variable: content_types in navigate\navigate_search\navigate_search.module on line 144.
# notice: Undefined variable: wid in navigate\navigate.module on line 591.
# notice: Undefined variable: output in navigate\navigate.module on line 444.
# notice: Undefined index: order in navigate\navigate.module on line 483.
# notice: Undefined index: 2 in navigate\navigate.module on line 606.
# notice: Undefined index: 2 in navigate\navigate.module on line 613.
# notice: Undefined index: 2 in navigate\navigate.module on line 606.
# notice: Undefined index: 2 in navigate\navigate.module on line 613.
# notice: Undefined index: name in navigate\navigate.module on line 692.
# notice: Undefined index: wid in navigate\navigate.module on line 846.
# notice: Undefined variable: output in navigate\navigate_favorites\navigate_favorites.module on line 169.
# notice: Undefined index: settings in navigate\navigate.module on line 493.
# notice: Undefined index: settings_button in navigate\navigate.module on line 558.
# notice: Undefined index: settings in navigate\navigate.module on line 569.
# notice: Undefined index: class in navigate\navigate.module on line 692.
# notice: Undefined index: name in navigate\navigate.module on line 692.
# notice: Undefined index: class in navigate\navigate.module on line 692.
# notice: Undefined variable: title_help in navigate\navigate.module on line 540.
# notice: Undefined variable: title_help in navigate\navigate.module on line 540.
# notice: Undefined variable: title_help in navigate\navigate.module on line 540.
# notice: Undefined variable: hidden in navigate\navigate.module on line 161.
# notice: Undefined index: name in navigate\navigate.module on line 692.
# notice: Undefined index: class in navigate\navigate.module on line 692.

Comments

yched’s picture

yched commented
Priority: Normal » Critical

+1
The module is spectacular, but currently unusable on development setups. Shipping without notices is important because we encourage site devs to turn error displays on, so that they can catch the warnings in their own modules. If a contrib module raises 10s of warnings on a page, they can't do that.
Bumping to critical.

redndahead’s picture

redndahead commented

stompeers,

I may be able to look into this as long as #331348: Remove windows style line breaks gets applied. My patches are looking kind of crazy at the moment because of all the whitespace etc. So I would like to see the white space fixed before I submit any new patches.

chrisshattuck’s picture

chrisshattuck commented

I'm having a dickens of a time trying to get notice errors to display for me. I can, for example, throw an 'echo $undefined' into one module and have it display the notice error, but if I try the same thing in the navigate module, I don't see anything. I'm currently trying to dig through and see why they're being suppressed.

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented

@stompeers: just try the module with Drupal 6.x-dev. you will see the notices

chrisshattuck’s picture

chrisshattuck commented

Allright, got it sussed out, and have removed all the notice errors I found. Please feel free to post if you find any others. I have committed this to the Drupal 6 dev branch, and it will be included in BETA3. Thanks!

chrisshattuck’s picture

chrisshattuck commented
Status: Active » Fixed
pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Version: 6.x-1.0-beta2 » 6.x-1.0-beta3
Priority: Critical » Normal
Status: Fixed » Active

notice: Undefined variable: toc navigate\navigate.module on line 73.

chrisshattuck’s picture

chrisshattuck commented
Status: Active » Fixed

Okay, fixed again, in Beta5.

eMPee584’s picture

eMPee584 commented
Version: 6.x-1.0-beta3 » 6.x-1.x-dev
Status: Fixed » Active 
notice: Undefined variable: hidden in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 161.
notice: Undefined index: name in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 692.
notice: Undefined index: class in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 692.

Please, please please enable displaying of all php warnings if you are releasing code to hundreds of sites. These errors are ridiculous and i couldn't even provide a patch because i was not able to infer the intention behind the code. The module is really an ubercool widget, but please take the simple steps needed to not cause site/module developers headaches.

eMPee584’s picture

eMPee584 commented

uuh wait there's MORE of them, ouch:

notice: Undefined variable: output in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 233.
notice: Undefined variable: search_content in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 262.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: menu_matches in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 291.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined variable: wid in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 290.
notice: Undefined index: id in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate.module on line 827.
notice: Undefined index: description in /var/www/drupal-hfopi/sites/all/modules/navigate/navigate_search/navigate_search.module on line 282.
markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Active » Postponed (maintainer needs more info)

I am curious if you are still having trouble with this or if this ticket should be closed. I am looking at the code, however it doesn't seem to be an issue anymore.

amitgoyal’s picture

amitgoyal commented
Component: Code » Code (PHP)
Status: Postponed (maintainer needs more info) » Fixed

Marking this 'fixed' as it'w working fine and nobody reported any more such issues.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.