extra "u" on line 230/233 of webform_report.module
decibel.places - November 7, 2008 - 20:51
| Project: | webform report |
| Version: | 6.x-1.8 |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | reviewed & tested by the community |
Description
line 230 db_query("UPDATE {webform_report}u
should be db_query("UPDATE {webform_report}
error generated:
user warning: Table 'Leadtrackeradmin.webform_reportu' doesn't exist query: UPDATE webform_reportu SET wnid = 16, kcid = 8, sort = 4, components = 'a:1:{i:-1;s:2:\\\"-1\\\";}', filter_type = 0, filter_value = '', results_per_page = 20 WHERE nid = '19' in .../sites/all/modules/webform_report/webform_report.module on line 233.
#1
Created a patch.
regards
#2
Same problem here. Please commit this patch and roll a new release. :-)
#3
Same here. Pa-pa-pa-paleeeease roll a new release. There are many patches that have been sitting stale for months now :))
#4
I also found this error.
Marking as critical as the bug renders the module unusable - i.e. cannot create a webform report.
#5
@#4 Magnity
please see patch in #1
@klance the patch has been tested and reviewed, please commit
#6
The extra "u" is still there. Not a big deal really to remove it, but it would be nice to not have there so that others don't have to change the module code.
#7
Same thing happened to me! Easy change, but should be fixed so others don't have this prob
#8
I corrected this issue too.
But I found another error:
#default_value for title and description in "add new form_report" form, has "t()" function translating dynamic values.
This is causing errors in non-english installation of drupal
I've done a patch for these two errors, so I'm not creating a new issue for this.
I tested this patch and it's working in my production site.
#9
At least a month later and it seems the problem(s) still exist.
Furthermore, my experience has been that even after applying #5 http://drupal.org/node/397300#comment-1629714 the criteria are still not saved.
Anyone else out there looking into this?
@klance
...is the module maintainer available for insight?
Thanks to all for the feedback so far..
#10
@ #9 LiveLoveWorkPlay
I am using webform report with the "u" removed on a couple of sites and it works...
I have not had to apply http://drupal.org/node/397300#comment-1629714 or any other changes apart from removing the "u"
I did not use the patch, but it looks fine to me.
#11
I think the issue is in
webform_report_criteria_form
within
webform_report.module
based on a cursory initial review.
so,
did a simple print test above the UPDATE in webform_report_update and then the node I was testing saved.
odd behaviour.. something is off.
I have to move on but will get back to this as some point, maybe as early as next week.
if anyone else can shed light on the matter... would appreciate it.
#12
here is a screencap showing the webform results
@LiveLoveWorkPlay: could your problem be caused by an error in the webform?
#13
submit