This patch moves the initial styling out of navigate.module and puts it into navigate.js. It also sets a js variable found in Drupal.settings.navigateOn instead of the separate variable added now. This will allow other modules to use the variable for example the module I'll be posting soon. It's also more drupalesque.

Again my patch removes whitespace on these files. I'll reroll if necessary after the whitespace is cleaned up.

CommentFileSizeAuthor
#4 js_styling3.patch3.72 KBredndahead
#3 js_styling2.patch2.92 KBredndahead
js_styling.patch14.52 KBredndahead

Comments

redndahead’s picture

redndahead commented
Status: Active » Needs review
chrisshattuck’s picture

chrisshattuck commented

Hi redndahead, now that the EOL characters have been removed, would you mind re-rolling this so I can better see the changes?

redndahead’s picture

redndahead commented
StatusFileSize
new js_styling2.patch2.92 KB

Re-Rolled as requested.

redndahead’s picture

redndahead commented
StatusFileSize
new js_styling3.patch3.72 KB

Previous had a bug when grabbing the Drupal.settings.navigateOn var. I fixed that plus I reversed the starting css so it starts closed. I did this so when JS is disabled it will not show. Currently if js is disabled it shows, but nothing works.

chrisshattuck’s picture

chrisshattuck commented
Status: Needs review » Fixed

Thanks for the patch, redndahead, I have applied it in Beta5. Cheers!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.