No "alt" tag in video thumbnail

bcobin - November 7, 2008 - 22:47
Project:OpenPackage Video
Version:5.x-3.13
Component:Code
Category:bug report
Priority:normal
Assigned:jbrown
Status:closed
Description

Have I told you guys (or girls) recently how much I love this module?

One small point: it seems that the module doesn't generate an "alt" tag for the thumbnail. Unfortunately, that breaks validation.

Let me know if there's a quick fix for this - otherwise, congrats on a brilliant module - it's the best out there. (I won't mention any names...)

Keep up the great work!

#1

bcobin - November 12, 2008 - 06:58

Easy - figured it out. I just inserted the following at line 125 of preview_image.inc:

$parts[] = 'alt=""';

Front page now validates. Woo hoo! Take a look here.

Open Package video rocks! Great work...

#2

ferrangil - November 26, 2008 - 16:52

Cool, I hope it will be added in new releases as it's always important to be valid :)

#3

jbrown - December 9, 2008 - 09:33
Assigned to:Anonymous» jbrown

#4

jbrown - December 21, 2008 - 19:22
Status:active» fixed

http://drupal.org/cvs?commit=160292

#5

ferrangil - December 22, 2008 - 09:16

But now is going to be blank, right? What about adding the title text into the alt tag...??

#6

jbrown - December 27, 2008 - 20:27

I just set it to "Video preview image". In the future we could also include the node title.

#7

System Message - January 10, 2009 - 20:30
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.