Have I told you guys (or girls) recently how much I love this module?

One small point: it seems that the module doesn't generate an "alt" tag for the thumbnail. Unfortunately, that breaks validation.

Let me know if there's a quick fix for this - otherwise, congrats on a brilliant module - it's the best out there. (I won't mention any names...)

Keep up the great work!

Comments

bcobin’s picture

bcobin commented

Easy - figured it out. I just inserted the following at line 125 of preview_image.inc:

$parts[] = 'alt=""';

Front page now validates. Woo hoo! Take a look here.

Open Package video rocks! Great work...

ferrangil’s picture

ferrangil commented

Cool, I hope it will be added in new releases as it's always important to be valid :)

jbrown’s picture

jbrown commented
Assigned: Unassigned » jbrown
jbrown’s picture

jbrown commented
Status: Active » Fixed

http://drupal.org/cvs?commit=160292

ferrangil’s picture

ferrangil commented

But now is going to be blank, right? What about adding the title text into the alt tag...??

jbrown’s picture

jbrown commented

I just set it to "Video preview image". In the future we could also include the node title.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

jbrown’s picture

jbrown commented
Title: No "alt" tag in video thumbnail » No "alt" attribute in video thumbnail
Project: OpenPackage Video » Blue Droplet Video
Version: 5.x-3.13 » 6.x-1.x-dev
Status: Closed (fixed) » Fixed

The alt and title attributes in the img tag now use the node title.

http://drupal.org/cvs?commit=316032

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.