Prepare a production release

Read the other issues in the queue for this module. There are at least 4 patches, without which it won't work. And there is at least one additional critical bug, a fix for which I have not yet been able to find.

Actually, from my experience, the module works out of the box ("works here"). It just a matter of enabling the module and (and dependencies) and using the right OpenID URL.

I can also confirm that the module works. There are minor problems, but all in all, it behaves in a sane way.

Working for me too, would be nice to have an stable release by the end of the code sprint, huh? :)

It kind of works. Just set it up on d6.drupal.org and tried to log in to dc2009.drupalcon.org earlier today. It worked. I believe the user interface of the provider module is obscure at best, and certainly needs more stuff for a drupal.org rollout. I *don't* think a 1.0 release would be fine with this obscure UI. Gonna submit issues to suggest fixes.

That it works using Drupal as both the provider and the relying party is just about accidental. In other words, there was one functional path through the code, but other paths of many to support the protocol failed.

I suggest we be a bit more thorough in our testing before pronouncing the code good enough to support the entire drupal.org infrastructure, or production usage by someone who wants to perhaps allow any relying party to work.

In fact, I suggest we test with a relying party that uses the de-facto standard JanRain OpenID libraries, since the vast majority of code out there uses them.

Note that the module passes the only test site I know for openid: http://openidenabled.com/resources/openid-test/diagnose-server/

Regarding #6: right now, my local provider passes all the tests on the JanRain test site, so I would guess we *are* compatible with those libraries. What else can we test?

#400154: Login fails with msg: "Error time_bad_sig:", for example, seems to say livejournal doesn't interoperate... is it livejournal's fault or ours?

I would go for a beta, after my patch in #396508: Make user/N/openid-sites themable and default to table display is committed of course. ;)

Any release lurking in the horizon? It would be nice to see this go through at /some/ point (and maybe think of d7?).

I think it's ready for a production release, provided some RTBC patches are checked in. In my opinion, those should be:

#441028: List OpenID Provider in OpenID package
#396468: Don't use underscores in URLs
#313848: Add section on admin page
#394114: Association expire, explain it at the UI
#394986: Improve readme

I also think that #396508: Make user/N/openid-sites themable and default to table display is *almost* ready and I'm ready to finalise testing on that one.

I think it's safe to say this was reviewed & tested: i've been using the openid_provider module with some of the above patches for a long time, without any significant problems. This should be released.

subscribe

subscribe

subscribe

subscribe

subscribe

subscribe

Note that a good release may want to include those too:

* #222044: Openid login failed with Blogger users
* #233885: [PATCH] Blogger Authentication Fix (OpenID 1.1 server compatibility)

But we've been waiting so long for a prod release that I wouldn't block on those.

subscribe

I was mistaken: #222044: Openid login failed with Blogger users is actually for the openid.module, not for the provider. Same for #233885: [PATCH] Blogger Authentication Fix (OpenID 1.1 server compatibility).

So again, roll call!

* #441028: List OpenID Provider in OpenID package
* #396468: Don't use underscores in URLs
* #313848: Add section on admin page
* #394114: Association expire, explain it at the UI
* #394986: Improve readme
* #396508: Make user/N/openid-sites themable and default to table display

*All* the above are now RTBC and we are fully ready for a release. Can we get the above in and a production release, please? Pretty please? Pretty please with sugar on top?

The above patches look good. walkah: can we get these 6 commits?

subscribe

#19 lookin' good to me.

Just rolled 6.x-1.0-beta1 .... marking this closed.

Before I release final - I wanna make sure that all compatibility issues are sorted. Please test!