Error saving OGUR config screen

Thanks for the quick patch !!!!

I just tried it and the patch failed. Maybe a line numbering issue??

Error from patch utility:

Patching file:  og_user_roles.module
Assertion failed:  hunk, file patch.c, line 321

is it easy to fix maybe?

did you download from cvs or from the project page? does it matter?
Mine was clean from the project page.

the patchfile for user.module included with the download worked fine on the user.module file ... so I don't think its my system or method for executing the patch process.

I just downloaded a fresh copy of 3.3 from the project site with the same result.

???

Ok... I finally got it to patch ...Yeaaaaa!

(there is some kind of problem in my downloaded version of the patch ... getting occasional square boxes mixed into the text when viewed in notepad. Don't know if this is a problem with the patchfile that's linked to the download or some corruption in the transfer ... I tried it several times. I am on a windows machine; guessing youre on mac or unix? So I finally viewed the link directly in mozilla and copy/pasted the result into a notepad file directly and ...voilla. Good code without little boxes.)

So, the patch worked and the new patched version in fact gives the newly promoted group admin the specified group admin role as advertised. That's the good news.

Bad news (or less than good news...) when I demote the admin back to normal group member, the privilages assigned by OGUR are not reverted back to the non admin role.

Is this what you intended or does it still need a touch of work?

Thanks so much for being so dilligent about this. It's refreshing and delightful to be user testing and actually get this kind of rapid, effective, and supportive response.

And, FWIW in case anyone else is having the same error issues mentioned above.

I think I have some info, but no tested solution yet (working on it)
After a little(lot) of searching, came up with... #165227: Admin Settings Error -- Warning: Table 'watchdog' was not locked with LOCK TABLES
??? don't know why this came up as strikethru??????

Seems that the length of the variable created when OGUR concatenates its variable name to my longish group name might be a problem.

Notice in the error message above, the two versions of what are being called a duplicate entry:

og_user_roles_assign_typegrouprole_group_generic
og_user_roles_assign_typegrouprole_group_generic_group

The first is a truncated (48 char) truncated version of the second. I checked in my database using phpMySQLadmin and found that indeed the variable table had a 48 character length defined for name entries.

This seems like a very silly limitation specified on drupal install and will break anyone's module who has no way of controlling the length of a finished variable name that depends on an unlimited original.

Shorter names here (OGUR) might help (if this really is the issue), but it doesnt really solve the larger issue. (which someone said is resolved in V6)
I suppose i can try editing the name length max manually in the database, but I'm pretty sure that will come back to bite me when I update or upgrade drupal.

Whew!!!!!

Somebodysysop you're a god.

Problem solved! (for me) I guess others may want to try the patch before closing the issue.

OGUR now (as patched) correctly confers the specified admin role access privilages when user is elevated to group admin and removes them when the group admin user demoted to "normal' group member.

FWIW, I also verified that this works correctly when multiple users are elevated to admin roles and that it does not alter other roles that these users are assigned either on promotion or demotion.

Great job. Hope others have the same results.
(I do wonder if I'm just the first to notice or if others don't experience my problem ...)

Thankyou.