Hi, first of all kudos for such a wonderful theme. I would like to report a missing semicolon (;) in line 398 of css/appearance.css.
line 398: font-size: 1.2em should be font-size: 1.2em;
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | appearance.css_.patch | 591 bytes | aimutch |
Comments
Comment #1
aimutch commentedPatch attached.
In testing, I noticed a couple of problems that are caused by fixing this "bug":
1. Size of text for Primary Links increases noticeably since the font-size is actually being applied.
2. It appears that this fix causes the menus to jump, perhaps due to the larger font size or some other issue in the CSS that needs to be addressed.
Both of these will need some discussion and further exploration.
Comment #2
aimutch commentedA follow-up to the previous comment. I'm suggesting the following changes to the code to fix the jumping menu problem when you fix the missing semi-colon. All in style.css:
#navigation ul a
change: padding: 0 1.25em;
to: padding: 0 1em;
Because the font-size of the text in the UL has increased, shrinking the padding down a little keeps the cell from being too wide (the padding is based on em's which means it's determined by the text size)
#navigation li
change: padding: 0;
to: padding-right: 0;
#navigation li.expanded
comment out both lines:
#navigation li.expanded {
/* padding-right: 0.65em; */
/* background-image: none; */
}
Add a new selector:
#navigation li.expanded a {
margin: 0;
}
Comment out padding-right
#navigation li.expanded:hover {
/* padding-right: 0; */
}
Comment out padding
#navigation li.expanded:hover a {
/* padding: 0 1.9em 0 1.25em; */
}
If someone else can test these changes including the original fix to correct the semi-colon, I'll do a patch if the results come back OK.
Comment #3
jacinethis is fixed in the new version :)