Figure out and apply coding standard for casting

I generally try to not argue too much about the color of the bike shed, but I really prefer the latter.

I prefer it with a space too.

I second that

Let's discuss over at: http://groups.drupal.org/node/16598, not here.

It looks like the discussion ended long ago, and casts should have a space between the (type) and the $variable.

I just added that to the coding standards page.

So it looks like the next step would be to make a patch.

Here is a patch.

I grepped with

\(.+\)\(.*\$.*\)

and

\(.+\)\$.+

I'm late to the party, but I fully endorse having the space. Drupal tends to respect/like a lot of whitespace anyway, so it just makes sense.

#6: casting_var.patch queued for re-testing.

Let's get this in before I have to reroll again :(

RTBC by #8

Personally, I like it better without the extra space.

hah, I just learned that I was somehow opposed to the space some time ago. In the meantime, I love it. ;)

It's not only consistent with other Drupal coding standards, but also consistent with example code in PHP's documentation, as Morbus correctly states.

The grep statistics in the OD of this issue should have changed in the meantime, as we apply this standard to new and changed code for quite some time already.

I agree with sun [for a change :) ].

#12: casting_var_V2.patch queued for re-testing.

Reroll

If this is green, please commit :( ...
I'll make followups if necessary...

This was RTBC before the reroll, setting back to that.

Patch no longer applies. Needs to be re-rolled.

Hopefully last reroll