I found that sphinxsearch form isn't provide ability to choose "Results per page" in advanced search form. This functionality is pretty important in large-scaled sites, so I've added it to the form. I linked it's default value to value which could be set at global administration of this module. Also, I removed some useless options from it's combo-box. I'm sure that "10, 20, 30, 50, 100" (like in Google's form) is better than old value.
Please review the patch. (And thanks for previous commits ;)
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | sphinxsearch.results_per_page.patch | 3.41 KB | neochief |
| sphinxsearch.results_per_page.patch | 3.33 KB | neochief |
Comments
Comment #1
neochief commentedFixed assert warning of sphinxsearchapi on int check:
$search_options['results_per_page'] = (int)$search_options['results_per_page'];(wonder why it triggered, but anyway, the warning gone)
Comment #2
markus_petrux commentedPlease, check out the list of TODO things that need to be done for the D6 version of this module:
http://drupal.org/node/306959#comment-1007276
Once hook_sphinxsearch_api() is done and working, I plan to add the ability to create profiles (or something similar) to build search page options. To do that, I'll probably move options that are now in the module settings panel to the "profile edit panel", there I could include an option to customize the number of results per page, which options are available for advanced search form, predefined filters, what should be available for faceted search block, etc.
I just need time to keep working on that... I hope to get into it next week, but it depends on daily job.
PS: Flagging the issue as "needs work", but it really depends on things that I still need to code.
Comment #3
markus_petrux commentedWent ahead and committed a slight variation of the patch.
- http://drupalcode.org/project/sphinxsearch.git/commit/0d76f3b
Thank you!
Comment #4
markus_petrux commentedOops!