cut the fat out of _drupal_bootstrap_full

will post some code soonish now that #325665: Cache registry lookups is in.

ok, here goes.

this is a kitten-killer right now, and not much of a looker either.

posting anyway, so chx can have a look at it.

one thing that this patch needs is contants defined by classes. right now, there's some ugly if (!defined('foo')) stuff.

if we have my_module::MY_CONSTANT, lazy loading via the registry will Just Work, which is nice. that will be separate patch very soon. if that lands, then this lazy loading idea really could happen without too much ugly.

also, #333143: bootstrap modules begone would make this patch less of a kitten killer, as would a patch to get rid of the remaining places where we use:

foreach (module_list() as $module)) {
  // do something with a hook on each module

and replace with:

foreach (module_implements($hook) as $module)) {
  // do something with $hook on each module

@Damien: yes, i think that's a good idea, and along with the other kitten-saving patches mentioned, will help to make this less ugly.

my intention with the first patch was just to get the tests to pass, see how ugly it looks and how we could break it up.

just noting that i've created #334024: Use const keyword to define constants instead of define().

just noting that i've created #334030: replace module_list with module_implements when calling a hook.

i'll update this patch in a day or two now that the module_list --> module_implements patch is in.

any comments on the contants in classes patch?

yay, more kittens - #287178: Use hook_form_FORM_ID_alter() where possible.

i'll work on that patch, because in reviving this one, i noticed that our hook_form_alter implementations load too much code, too much of the time.

attached patch is updated for HEAD, and is a tiny bit less ugly after some of the kitten-saving patches landed.

also, rolled in the comment constants in a class as per #334024: Use const keyword to define constants instead of define() - can't really see that going in separate from this patch.

still not ready by any means, but don't want to let it drift too far, and setting to code needs review to get eyes on it. all tests pass.

for those who want to look at areas where drupal loads lots of code for no good reason, a) patch menu_get_active_help to return immediately:

function menu_get_active_help() {
  return '';
  $output = '';

then run this from the drupal root:

justin@ubuntu:~/code/drupal/7/registry$ for module in `ls modules/*/*.module` ; do echo "watchdog('wtf_another_module_loaded', __FILE__);" >> $module ; done

click around and see what you get.

boo, hiss, not sure why the testbot is unhappy.

also, swentel pointed out in #drupal that the watchdog calls don't work, so:

justin@ubuntu:~/code/drupal/7/registry$ for module in `ls modules/*/*.module` ; do echo 'file_put_contents("/path/to/log/file", __FILE__ . "\n", FILE_APPEND);' >> $module ; done

updated patch to keep up with HEAD.

also, converted comment.module and profile.module constants to class constants.

all tests pass, except from "Menu item creation/deletion", but that's failing on HEAD anyway.

@Dries and Crell: i'm not a huge fan either, but we need some way to make constants lazy-load if we are going to move away from just loading all enabled modules.

so, either we find another way to make them available, or we give up on lazy-loading .module files.

i'm happy enough to drop this if noone else thinks its a good idea. getting a working implementation has uncovered some useful patches, so its been worth it i think.

@Crell: if you can flesh out your 'lets use the registry to load less code ideas' further by creating an issue/blog entry/dev list post, i'm happy to work with you on the implementation.

closing this issue after a discussion with Crell and webchick in #drupal.

will continue the "lets load less code" battle here at #340723: Make modules and installation profiles only require .info.yml files.