Hi Merc,
Mega-Mega Congratulations on Drigg 6x-dev to you and all the Driggers community!!! Great things are ahead!
I started testing it immediately. All the basics seem to work fine. There just 2 problems that I bumped into so far:
first is with Drigg Theme itself. If you try to optimise the site and enable the "Otimize CSS files" (in Drupal6 > Performance), then what happens is that the Drigg Theme "collapses". -- it just becomes a black on white listing, as if there was to CSS to give shape to it.
Yes, yes - I know -- this is "theme-related", I shouldn't be reporting it. But many of us use Drigg Theme as the basis for constructing our own theme. So this bug report is valid.
(the second problem , I'll report as a separate issue)
Comments
Comment #1
mercmobily commentedHi,
I have _no_ idea why this happens, and don't have the means to investigate it.
I won't be working on closing this issue -- is somebody out there able to pinpoint the problem and offer a solution?
Merc.
Comment #2
Jeff Burnz commentedWell little bit late but I stumbled onto this and I have a hunch - I've seen this once before on one of my sites, turned out to be a permissions issue which prevented the aggregated CSS file from being saved to the server.
Comment #3
mercmobily commentedHi,
drupalina: could what jmburnz say be "it"?
Merc.
Comment #4
ajayg commentedJust additional info. Optimize CSS works fine in 5.x. So either something got changed in 6.x theme or there is problem elsewhere.
I would strongly suggest to retest with drigg theme out of the box. I had noticed some simple(I thought !) modifications I made to the theme and it was giving problem. Found cause was my modification and not the theme. This is true for several other drupal themes.
Comment #5
drupalina commented@jmburns - not clear. Could you say more? Which exactly permission do you have in mind?
@ajayg - my Drigg_them is in fact out of the box - no changes. I just installed Drigg 6x_dev to help the testing process.
Comment #6
Jeff Burnz commentedThe files directory was not writeable in this case, because I had forgotten to make it so, i.e. chmod 777.
Comment #7
drupalina commentedok... I changed it to 777, but that didn't have any difference. Drigg_theme still collapses when you try to optmise CSS.
BTW, in Drupal 6 the path for "files" directory is /sites/default/files -- could this be a factor?
Comment #8
Jeff Burnz commentedYou need to post a link to the test site where you're testing this stuff, otherwise its all guess work.
Comment #9
drupalina commented@jmburnz - I've sent you the URL link via your e-mail contact form
Comment #10
mercmobily commentedHi,
Please keep me informed on this one!
Thanks a million everybody...
Merc.
Comment #11
Jeff Burnz commented@drupalina et al, I'm gonna download it and start messing about in the next couple days.
Comment #12
drupalina commentedanybody else seen this problem?
any updates anyone?
Comment #13
philbar commentedI have experienced similar problems in the past. I don't think this is a bug with Drigg, so I will change it to a support request.
When Drupal Optimizes CSS, it creates a new CSS file in your /files directory. Sometimes when directory permissions aren't configured properly on your web server, it prevents drupal from creating the new CSS file.
Do you see a CSS file in your /files directory?
If you don't, then you need to research the issue on Drupal.org and try to change the permissions on the /files directory.
Comment #14
mercmobily commentedHi,
Sorry, nobody seems to follow up on this one, considering it closed since I can't reproduce it!
Merc.
Comment #15
Netzarim commentedI just installed this version yesterday. I am having the same issue. I notices in /sites/default/files/css there are 3 files created, but one of them has 0 bytes. I suspect that 0 byte file is the issue, but am unsure how to proceed in correcting it.
The only modification I have is to page.tpl.php, in the location where google adsense is indicated I have added my adsense code (Although I dont see the ads yet).
Eric
Comment #16
drupalina commentedI'm still having this issue.
@philbar and @jmburnz -- my /files directory is located under /sites/default/files (apparently that's the new way to do things with Drupal 6x). The file directory's permissions are set to 777. Inside /files I also have 2 more directories /css and /js. Those directories also have 777 permissions.
Why I believe that this is a Drigg_theme issue rather than folder permissions hickup? Because, as Netzarim has confirmed, new aggregated css files start appearing in /files/css folder even with Drigg_theme. So permissions is not the issue. When I switch to 4Plus theme or Garland , or any other theme, this isssue doesn't happen and the theme is displaying as it should. So there's some weird hickup in the Drigg_theme!!!
It would be nice if some theminging guru would provide a simple clean theme for drigg (hopefully based on Zen), so that Driggers can start using it as a basis for their theme modfications.
Can someone actually confirm that they have a Drigg_theme up and running in 6x and with CSS optimised, which appears all okey?
Comment #17
wwwoliondorcom commentedHi,
Is CSS optimised option really useful with Drigg websites?
Can you explain why ?
Thanks.
Comment #18
drupalina commented@wwwoliondorcom -- Optimizing CSS is indeed very useful for Drigg sites, because Drigg sites have a LOT of additional custom CSS, which becomes quite bulky. Aggregating those multiple CSS files and minifying that CSS (plus also tweaking in .htaccess) will significantly improve the pageload speed. Most people come to Social-Filtering (aka Digg) sites to simply find interesting and useful content and leave. So the site must be pretty fast.
Comment #19
wwwoliondorcom commentedThank you for your explanation, so you advise to turn Aggregate and compress CSS files ON with Drupal 5 Drigg 5 website also ?
No known problem with Drupal 5 ?
And what should be tweaked in .htaccess ?
Thanks again.
Comment #20
drupalina commented@wwwoliondorcom -- you are diverging from the main issue that this topic is dedicated to. Each topic should keep its focus, if any solution is to come (That's the lesson that we learnet from Merc!) But, yes, I recomend turning it on in Drupal 5 (no problems). With regards to .htaccess tweaks to make your site faster, read loads of info on how to optimise Drupal performance and speed.
Comment #21
wwwoliondorcom commentedSorry ;-)
So, what we are looking for is a simple clean theme for drigg (hopefully based on Zen), so that Driggers can start using it as a basis for their theme modfications.
Thanks.
Comment #22
Netzarim commentedStill, if you select to optimize CSS for Drigg in Drupal 6.10, it breaks the CSS. That is what we are attempting to solve for here. This will consistently fail a YSlow test if not enabled and, currently, enabling will break the site.
Comment #23
alliax commentedI confirm that is the case, I always do it with all my other sites in D6 and D5 so it's not related to a folder permission. It has to do with this specific theme. But I've seen other old and recent issues in other themes where people have a problem with optimise CSS files, but no solution found, I directed them to this issue so maybe they'll come and help us if they've found a solution.
Comment #24
netrelief commentedI have reason to believe that one of the major problems is the css references to images. images that use '../' paths in the css seem to break when optimize css is turned on. Can anyone else confirm?
edit:
I am now certain that the relative path structure of using '../' is the cause of the image dropout when using optimize css.
Comment #25
alliax commentedI modified paths (removed ../ in paths) moved the .css files in the main directory (out of /css) and also modified base.css to reflect the move, it works the same as before, and when i optimize css still same problem.
Did you succeed netrelief?
Comment #26
netrelief commentedJust as a precaution, did you remeber to delete the cached css files?
Comment #27
alliax commentedNo I didn't delete anything in drupal, I simply tried with caching off and only optimize CSS, but I'll try now.
But in my browser yes I deleted cache. I'll try finding and deleting any .css file in drupal files folder.
Also note that in Drigg for D5, the CSS were the same, there existed an optimize CSS files which works. It doesn't work only in D6.
EDIT: yes, I removed all cache files in /files/css/ and tried with cache off, no optimize javascript, only optimize css, and still doesn't work.
The header is fine, but the categories nav bar is unstyled, then comes the content and then left and right columns come after the content, one above the other.
Comment #28
netrelief commentedI reloaded everything, and have been trying to tweak the files. I can get most of it working , but certain elements still are missing their style information. Something is breaking during the optimize process. I end up with CSS lines like:
background-image:url(/drupal/themes/drigg_theme/./width:30px;I cannot figure out why yet. I am going to study a working theme to see if I can compare. The CSS files definitely cannot be in a deeper directory that much is clear.
Comment #29
dev-buenlink commentedHello,
Here is the Fix for Optimise CSS files in Drupal 6.x
1. go into the drigg_theme/drigg_theme.info and add:
stylesheets[all][] = css/base.css
stylesheets[all][] = css/blocks.css
stylesheets[all][] = css/misc.css
stylesheets[all][] = css/nodes.css
2. Go into the drigg_theme/style.css
delete any data in that file.
3. Clear cache and it works =)
Thats how we fixed it.
you can see it in action, www.buenlink.com
Comment #30
alliax commentedThank you very much buenlink, I tried it and I confirm it works fine.
Since I previously deleted the css folder and modified the path in the 4 css files, I modified the 4 lines like this
stylesheets[all][] = base.css
stylesheets[all][] = blocks.css
stylesheets[all][] = misc.css
stylesheets[all][] = nodes.css
and emptied the styles.css (I think we can even delete it and remove the related line in drigg_theme.info)
And after I enabled optimize css files, and it works perfect.
Thank you very much!
ps: you have a very nice theme on your drigg site
Comment #31
mercmobily commentedHi,
WOW... this was a long standing bug!!!
Nice one!!!
Merc.
Comment #32
wwwoliondorcom commentedThanks ! it works !
Comment #33
dev-buenlink commentedNo problem, glad we can help. =)
We are looking back through these threads and looking for what needs to be completed for version 6.x
We might be able to help.
Comment #34
mercmobily commentedHi,
@dev-buenlink : are you really able to lend a hand with Drigg?
I've just stepped in developing it again, after the new "maintainer" abandoned it for months and didn't respond to any of the community messages for months.
I really, really, really want to get to the point where there are no outstanding bugs, but just feature requests.
Can you *please* lend me a hand? I will appreciate it immensely...
Bye,
Merc.
Comment #35
dev-buenlink commentedHi Merc,
definitely yes.
we are are currently testing the fix for the time issue.
#337746: modifying scoops resets "made popular time"
Just want to make sure it is 100% and we will hopefully help resolve that one.
bye
Comment #36
mercmobily commentedHi,
OK, I understand exactly what was going on. People who ported the theme had made a mistake. Sorry about that...
Fixed in CVS. Please test the developer version when it's available. If it still has problems (but I don't think so), reopen this. Hopefully not, the fix was very trivial...
Merc.
Comment #38
drupalina commentedJust letting you know: I've tested the latest .dev version of drigg with its included drigg_theme on my localhost Drupal 6.12 installation, and it looks like this problem has gone away. Thanks a bunch, Merc!
Haven't tested it in a live environment, but I'm sure it should be fine.
Sorry, for the late reply. After Merc quit drupal and drigg, my drigg site gradually lost steam and died away too, because many features remained broken or half-baked. But now that Merc is back, I'm gonna try to resurrect it again in 6x toward end of July, so hopefully we'll be getting feedback from end-users too. But it might take time to get back into the speed.
Comment #39
Gord_Mason commentedCan you explain the mechanics of your fix? I have created my own theme, and have a similar problem (CSS optimization breaks image loading). The problem for me is that background-image selectors have seem to lose the quotes around the argument within parantheses, e.g. "background-image: url(/newsite/sites/sitename/theme/image.png);" as opposed to "background-image: url('/newsite/sites/sitename/theme/image.png');". If I modify the aggregate css files to include the quotes, the theme works properly.
Gord
Comment #40
Macronomicus commentedI second that ... my @font-face stuff gets wiped, The sad thing is that I only need to enable css optimization so IE doesnt piss on itself but IE cant even comprehend @font-face so its killing it both ways arrrg!! I hate IE!
Comment #41
Macronomicus commentedNevermind that ... make sure your quotes are proper... even though most browsers would read the following without quotes around the url the drupal CSS aggregation no likey and it drops them.
@font-face {
font-family: mytitles ;
src: url("../theme/fonts/42______.TTF") format("truetype");
}
Comment #42
thereminist commentedHi,
how do you fix this issue in STARTERKIT (ZEN) ?
Thanks for your help in advance.
Comment #43
aaronelborg commentedSubscribing.