My dhtml_menu 6.x-3.0 installation was working fine, with Drupal 6.6. I just upgraded to 6.x-3.1, and how I get the following errors on every page:

warning: array_pop() [function.array-pop]: The argument should be an array in /home/share/devel/commercekids.org/src/trunk/sites/all/modules/dhtml_menu/dhtml_menu.module on line 127.
warning: end() [function.end]: Passed variable is not an array or object in /home/share/devel/commercekids.org/src/trunk/sites/all/modules/dhtml_menu/dhtml_menu.module on line 83.
warning: current() [function.current]: Passed variable is not an array or object in /home/share/devel/commercekids.org/src/trunk/sites/all/modules/dhtml_menu/dhtml_menu.module on line 86.

The above repeats several times. Reverting to 6.x-3.0 makes the problem go away again.

Thanks,
Andrew.

CommentFileSizeAuthor
#1 dhtml_menu_initialize_array-332156-1.patch640 bytescburschka

Comments

cburschka’s picture

cburschka
they
commented
Title: array errors after update to 6.x-3.1 » static array needs to be initialized.
Status: Active » Needs review
StatusFileSize
new dhtml_menu_initialize_array-332156-1.patch640 bytes

Ah, I see what happens. There is an array that is not initialized properly. Easy to fix.

Does this affect the functionality in any way, or is the warning the only thing you notice?

Andrew Schulman’s picture

Andrew Schulman commented

AFAICT there's no effect except for the long string of error messages.

I applied the patch, and the error messages have gone away.

Thanks!
Andrew.

cburschka’s picture

cburschka
they
commented
Version: 6.x-3.1 » 7.x-1.x-dev
Status: Needs review » Patch (to be ported)

Committed to DRUPAL-6--3. Problem may exist in HEAD too.

cburschka’s picture

cburschka
they
commented
Status: Patch (to be ported) » Fixed

Patch still applied cleanly. Committed to HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.