Code has some inconsistencies re: the drupal coding standard. (http://drupal.org/coding-standards) Patch attached.

CommentFileSizeAuthor
mint_cleanup.patch10.47 KBcrookednumber

Comments

alexmarkley’s picture

alexmarkley commented
Status: Needs review » Closed (won't fix)

This module is developed and maintained by my company internally, and drupal core's coding standard conflicts with my company's internal coding standard. I was told that drupal core's coding standard isn't enforced on contrib modules, so in this case my company's standard supersedes drupal's.

If you have a recommendation for improving code quality or functionality, please feel free to submit it. But I'm probably not going to consider merging a patch which simply reformats code unless somebody presents a pretty compelling argument.

ttyl!
--Alex

crookednumber’s picture

crookednumber commented

Thanks for the explanation. You are right; coding standards are not 'enforced' on contrib. I didn't mean to imply otherwise. In fact, very little is enforced. But they are definitely and strongly encouraged, in any piece of code (contrib, core, snippet, etc.) If you're looking for a compelling argument, it's probably simply this: you'll be judged by your code, including your commitment to code consistency.

But if your hands are tied, your hands are tied. Still, you might want to do something like add a comment in your code explaining why it's formatted differently. And maybe look into drupal-specific tweaks that are also compatible with your company's code standards: e.g., adding doxygen comments (http://drupal.org/node/1354).