As I looked for this issue into the code of the book.module i realized that there are a lot of hardcoded html in it
and this is now what i want to fix.
Beside this the only(!) themeable function in book.module is theme_book_navigation() and has far too much hardcoded

I will release a patch within this day...

greets tobias

CommentFileSizeAuthor
#5 book.module_11.patch3.71 KBTobias Maier
#1 issue33220_book.module.patch3.72 KBTobias Maier

Comments

Tobias Maier’s picture

Tobias Maier commented
Status: Active » Needs review
StatusFileSize
new issue33220_book.module.patch3.72 KB

and here it is :D

I cleaned up theme_book_navigation()
now it does what it promises it makes just the book navigation

I introduced a new themeable function theme_book_export_html()

there are more unthemed html tags. but i think these are to minor to be themed...

moshe weitzman’s picture

moshe weitzman commented

the theme_export function looks good ... to me, it makes sense to keep breadcrumb generation out of theme function. thats semantic, not presentation.

Tobias Maier’s picture

Tobias Maier commented
Status: Needs review » Reviewed & tested by the community

has anyone concern about it?
I think it is not that overcomplicated patch so I set it to ready to be commited

dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs work

Haven't looked or reviewed this patch but clearly, it no longer applies against HEAD.

Tobias Maier’s picture

Tobias Maier commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new book.module_11.patch3.71 KB

CVS HEAD...

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)