Posted by Tobias Maier on October 6, 2005 at 2:34pm
| Project: | Drupal core |
| Version: | x.y.z |
| Component: | book.module |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Tobias Maier |
| Status: | closed (fixed) |
Issue Summary
As I looked for this issue into the code of the book.module i realized that there are a lot of hardcoded html in it
and this is now what i want to fix.
Beside this the only(!) themeable function in book.module is theme_book_navigation() and has far too much hardcoded
I will release a patch within this day...
greets tobias
Comments
#1
and here it is :D
I cleaned up theme_book_navigation()
now it does what it promises it makes just the book navigation
I introduced a new themeable function theme_book_export_html()
there are more unthemed html tags. but i think these are to minor to be themed...
#2
the theme_export function looks good ... to me, it makes sense to keep breadcrumb generation out of theme function. thats semantic, not presentation.
#3
has anyone concern about it?
I think it is not that overcomplicated patch so I set it to ready to be commited
#4
Haven't looked or reviewed this patch but clearly, it no longer applies against HEAD.
#5
CVS HEAD...
#6
Committed to HEAD.
#7