Query to remove actions from the database after their host module has been disabled is broken [#332266]

DBTNG no longer supports chaining on db_select(), so lines 286-290 of actions.inc don't work.

The code currently reads:

      $results = db_select('actions')
        ->addField('actions', 'aid')
        ->addField('actions', 'description')
        ->condition('callback', $orphaned, 'IN')
        ->execute();

We probably want something more like:

      $query = db_select('actions');
      $query->addField('actions', 'aid');
      $query->addField('actions', 'description');
      $query->condition('callback', $orphaned, 'IN');
      $results = $query->execute();

However, if #314464: Convert db_placeholders() to DBTNG is resolved, this should probably be changed into a static query using db_query() rather than db_select().

Comment	File	Size	Author
#10	332266_actions_query.patch	1012 bytes	mr.baileys
#9	332266_actions_query.patch	1012 bytes	mr.baileys
#6	332266_actions_query.patch	1.02 KB	mr.baileys

Comments

Comment #1

dave reid

he/him

English

Nebraska USA

commented 10 November 2008 at 02:04

Yeah that was my bad. I didn't know that db_select couldn't be chained like db_insert/update/delete...

Comment #2

dave reid

he/him

English

Nebraska USA

commented 19 November 2008 at 01:34

Assigned:

Unassigned

» dave reid

Assigning myself to fix this.

Comment #4

dave reid

he/him

English

Nebraska USA

commented 17 January 2009 at 06:54

Issue tags:

+actions

Comment #5

dave reid

he/him

English

Nebraska USA

commented 8 March 2009 at 00:10

Priority:

Normal

» Critical

Comment #6

mr.baileys

Dutch

🇧🇪 (Ghent)

commented 16 March 2009 at 12:36

Status:

Active

» Needs review

Status	File	Size
new	332266_actions_query.patch	1.02 KB

I ran into this issue while working on #306662: Add redirect option to site-wide contact forms.

@Dave Reid, I hope you don't mind but since I had to get past this error I rolled a patch according to cwgordon7's instructions...

Comment #7

cwgordon7 commented 16 March 2009 at 17:16

Well, since #314464: Convert db_placeholders() to DBTNG has been resolved, I believe this query can probably be converted to a static db_query() query?

Comment #8

dave reid

he/him

English

Nebraska USA

commented 16 March 2009 at 19:41

Status:

Needs review

» Needs work

@mr.baileys No problem at all. :)

Agreed with cwgordon7. This can be a nice db_query()->fetchAll() function now.

$actions = db_query("SELECT aid, description FROM {actions} WHERE callback IN (:orphaned)", array(':orphaned' => $orphaned))->fetchAll();
foreach ($actions as $action) {
  ...

Comment #9

mr.baileys

Dutch

🇧🇪 (Ghent)

commented 17 March 2009 at 13:24

Status:

Needs work

» Needs review

Status	File	Size
new	332266_actions_query.patch	1012 bytes

re-rolled taking the comments from #7 and #8 into account. If this gets commited, credit goes to Dave Reid and cwgordon7, as I merely poured their code into patch-form.