After enable Pagination in story node type, plus1 widget doesn't show up.http://drupal.org/project/plus1

Disable Pagination and it works fine.

Comments

mundanity’s picture

Assigned: Unassigned » mundanity

Hi Marco,

Thanks for the feedback, I've installed Plus1 to take a look, it looks like it adds a <div> to the end of the node's body. If you install Plus1 after Pagination, they can both exist without issue. I imagine you have installed Pagination after Plus1, at which point Pagination will interfere. I'll think about the best way to approach this and get a fix out as soon as possible.

marcolam’s picture

Actually,I installed Pagination before Plus1 on the above site.
Today I setup a new drupal site with only two addional modules:plus1 and pagination,plus1 installed before pagination,and it worked with no problems.
I guess this maybe involed with some other modules?

mundanity’s picture

Hi Marco,

I'll take a closer look, but from what I can tell, Plus1 modifies the content at hook_nodeapi(). Pagination handles pagination at hook_nodeapi(), then later it does a few things at hook_preprocess_node(). From what I could tell, Plus1 was adding the info to the body, and then Pagination was paging over it. If Pagination got to it first, then Plus1 could tack it's content on. I should be able to work around it without much issue, I'll try get a patch out in the next few days to address that.

mundanity’s picture

Status: Active » Postponed (maintainer needs more info)

Hi Marco,

Have you been able to reproduce this error on your new install at all? I can't seem to trigger this problem with just plus1 + pagination installed. Would you be able to get a list of modules from your other site that may be relevant to this issue?

marcolam’s picture

I have quick a few of addional modules installed.I disable all of them except pagination and plus1,and plus1 widget doesn't show on pagination enabled node type.(other types with no pagination enabled are fine)

Today I installed pagination dev version and issue fixed.

Thanks!

mundanity’s picture

Status: Postponed (maintainer needs more info) » Closed (fixed)

Hi Marco,

Weird, good to hear though I guess, let me know if you notice any more odd behaviour :)