Allow Circular Wrap

Rabbit69 - November 10, 2008 - 07:41
Project:Views carousel
Version:6.x-2.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:mfer
Status:fixed
Description

I'ld like an option to define a cylce mode instead of foreward/backward sliding and reset to start.
Do you think it's possible to integrate this option.

#1

mfer - November 11, 2008 - 13:53

This module is a wrapper for jcarousel. If you can do it with jcarousel it can be implemented here. See http://sorgalla.com/jcarousel/

#2

Rabbit69 - November 11, 2008 - 13:57

jcarousel can do it, it's called circular caruousel.
Look at this http://sorgalla.com/projects/jcarousel/examples/special_circular.html

#3

mfer - November 11, 2008 - 14:17

I see what you are getting at. There is an issue where it works file in jQuery 1.2.3 but not quite right in jQuery 1.2.6. I commented out the option in the options form. There is an issue with jcarouse3l that needs to be worked out.

To see the problem in action go into the file viewscarousel_style_plugin.inc and see the comment on the last option on the $form array. You can add 'circular' => t('Circular'), to the list of options and then give it a go.

#4

mfer - November 19, 2008 - 02:20
Status:active» postponed

Postponing this until jcarousel is fixed for this to work. The issue is with jcarousel.

#5

fm - April 13, 2009 - 13:04

JQuery is up to v1.3.2 now. Has cycle mode been investigated recently? The current viewcarousel reset-to-start effect is not pleasing.

Also of interest might be: http://www.malsup.com/jquery/cycle/

#6

Rob Loach - April 13, 2009 - 21:04
Title:make cycle mode available» Allow Circular Wrap
Version:6.x-1.x-dev» 6.x-2.x-dev
Status:postponed» active

That's the jQuery Cycle plugin and isn't really related to jCarousel.

We could look into the circular wrap in the 6.x-2.x-dev branch because it now uses the jCarousel module, which supports the JavaScript callbacks. The reason the circular wrap doesn't work is because we HAVE to register some callbacks (as seen here, and that support wasn't available in the 6.x-1.x-dev version of Views Carousel. Now that callback support is in available, we could look into adding the circular support.

#7

Rob Loach - April 14, 2009 - 16:51

Here's the Views Cycle module: http://drupal.org/project/views_cycle

#8

fm - April 14, 2009 - 20:12

Yes, I ran across that and it's a consideration; however, it would be nice not to have to set everything up again.

Plus, views carousel really does need this cycle feature. The manner the reset is handled now isn't visually pleasing.

I hope you developer folks are discussing the creation of an über views carousel/rotator/slide module to combine the best of the field.

#9

jjesus - June 8, 2009 - 05:38

Subscribing. I have both a horizontal and a vertical going, works great. Would love to have them circular instead of swing back to beginning.

#10

pau1y - June 13, 2009 - 12:55

Yep, me too. I am using views-carousel (thanks for the module!) and it would be great to see it with a circular wrap feature one day.

#11

webwriter - June 13, 2009 - 14:13

Subscribing

#12

jjesus - July 2, 2009 - 10:39

Great module.

If you send me some pointers, I will try to come up with a patch to add circular support.

#13

mfer - July 2, 2009 - 12:28
Assigned to:Anonymous» mfer

@jjesus - the issue is a compatibility one. The jcarousel plugin with jQuery 1.2.6+ has a bug where the circular feature doesn't work. To make it work here we need to fork jcarousel and fix the bug.

I will be fixing this issue in the next couple weeks and need to keep a forked version somewhere.

#14

mfer - July 18, 2009 - 12:12
Status:active» needs review

Due to the way the jcarousel module is setup and used I couldn't find a good way to add the circular feature to the 2.x version of views carousel. But, I was able to add this feature to the 1.x branch. Please let me know if it's working for you.

Currently, in order to add it to the 2.x branch means forcing certain callbacks in the jcarousel module and removing some flexibility other modules may want to take advantage of. Working on a better way now.

#15

jjesus - July 25, 2009 - 15:11

Hi, Matt,

Thanks so much for doing this work!

The circular wrap works for me, both horizontal and vertical. I upgraded/downgraded from Carousel 2.x to 1.x. All my theming was preserved, which was a nice surprise.

My upgrade procedure was something like this (YMMV):

1. Disable viewscarousel 2.x. My 2.x version was in sites/all/modules
2. Untar viewscarousel 1.x in site-specific directory sites/example.com/modules
3. Enable 1.x version
4. Edit the view and select circular

I only wish the scrolling was a little smoother like the flash carousel on this site:

http://www.sab.org/

Otherwise, 1.x circular works great.

Cheers.

--John

#16

jjesus - August 5, 2009 - 03:06

You can see the circular wrap here:

http://www.aidantbooks.com

Vertical version:

http://aidantbooks.com/content/about-us

#17

wilgrace - August 17, 2009 - 18:40

Hm, my themeing has been thrown out by the downgrade to 1.x so can't go with this, though pretty keen on circular transition. Hope you manage to crack it for 2.x mfer...
thanks

#18

Rob Loach - August 20, 2009 - 01:09

What's missing from Views Carousel 2.x that allows the wrapping?

#19

alex_andrascu - August 24, 2009 - 16:28

I would really like to have this in 2.X branch too...Subscribing

#20

quixxel - October 1, 2009 - 19:17

subscribe...

#21

Rob Loach - November 5, 2009 - 20:31
Status:needs review» fixed

Haffmans hit up #619958: Support Circular Carousels. So it's part of the Views Carousel 6.x-2.x-dev branch now. http://drupal.org/cvs?commit=284608

#22

CinemaSaville - November 5, 2009 - 22:07

Looks like it's only been included in the 6.x-1.x version. Am I missing something?

#23

mfer - November 5, 2009 - 22:17
Status:fixed» active

I only added it to the 1.x module. I'm working through the 1.x version to clean it up. There are a bunch of people using it and there is really just a few bugs to fix and then it's really production ready. Then i'll update the 2.x version and get a release out. It will include some of the new features people want.

So, I'll open this one back up.

#24

Rob Loach - November 5, 2009 - 22:58

Haffman added the support to jCarousel module at #619958: Support Circular Carousels. I committed the option availability to Views Carousel 2.x branch at http://drupal.org/cvs?commit=284608 . Both 1.x and 2.x have the circular wrapping now :-) . Just wait for a dev snapshot update of both Views Carousel and jCarousel modules.

#25

mfer - November 5, 2009 - 23:24
Status:active» fixed

Yay!

 
 

Drupal is a registered trademark of Dries Buytaert.