The GET parameter "?d=xxxx" is missing on last gravatar version, which introduced identicon/* gravatar support. URLs are generated this way:

http://www.gravatar.com/avatar/7bf1cf98252aba31f56ccce4788874d6&s=48&r=PG

I have attached a simple patch to correct this small mistake :)

CommentFileSizeAuthor
gravatar_identicon_miss.patch471 bytesadobo

Comments

Narno’s picture

Narno commented
Assigned: Unassigned » Narno

;-(

I commented the code just below but I did propagate the change on the switch. Shame on me!

Thank you for feedback.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

So should the code be the following?

    switch (variable_get('gravatar_imagedefault', 0)) {
      // drupal default picture
      case 1:
        $path = variable_get('user_picture_default', '');
        // If the user has specified a relative directory for user pictures, make sure we send an absolute path
        $path = url($path, array('absolute' => TRUE));
        $gravatar .= '?d=' . urlencode($path);
        break;
      // gravatar module default picture
      case 2:
        $path = $GLOBALS['base_url'] .'/'. drupal_get_path('module', 'gravatar') .'/avatar.png';
        $gravatar .= '?d=' . urlencode($path);
        break;
      // gravatar default picture
      default:
        $gravatar .= '?d=' . gravatar_translate_type();
    }
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

I fixed this in latest 6.x-1.x code.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.