Port Comment alter taxonomy module to D6

Yes, that will happen eventually, but I don't have immediate plans to do so. Patches are welcome, of course.

Thanks for getting this started. Here are some brief comments, without having taken much time yet to look at this:
1. I'm not sure why you removed this line:

-dependencies = taxonomy comment

2. Looks like you accidentally changed this comment.

- * Allows users with proper permissions to alter the taxonomy of a
+ * Allows users with proper permissions to  the taxonomy of a

3. I'm guessing you used a find/replace and accidentally removed "alter" from text for some reason.

+    'description' => 'Enable/disable vocabularies that users may  from their comments.',

4. Another typo.

- * Implementation of hook_form_alter().
+ * Implementation of hook_form_().

and

-        // Prevent user from changing the terms for any vocabulary that can be altered from a comment with this
+        // Prevent user from changing the terms for any vocabulary that can be ed from a comment with this

There are other places where you've deleted "alter", but I'm not going to list them all here. Please go through the diff line by line and make sure that you actually meant to make every change that you made.

5. You've got various places where you've added whitespace that doesn't seem necessary.

6. You removed the period in a few spots.

- * Implementation of hook_project_issue_metadata().
+ * Implementation of hook_project_issue_metadata()

- * Implementation of hook_nodeapi().
+ * Implementation of hook_nodeapi()

7. You introduced a typo:

-      // Before this function returns these values in $metadata will be checked and any
+      // Before this function returns these values in $metadata will be cheked and any

8. TODO placeholders in the description fields need to be added in comment_alter_taxonomy_schema().

9. Also in comment_alter_taxonomy_schema(), I'd prefer that we use TRUE and FALSE, not 1 and 0, for boolean values. This affects the 'unsigned' array elements.

10. You've changed the primary key of the {comment_alter_taxonomy} table:

+    'primary key' => array('nid', 'cid', 'tid'),

I'm not sure why you've done this. If it's actually necessary, we will also need a db update function since the current primary key is just 'nid, cid'.

11. These three lines can be deleted, not just the middle one:

   if (db_table_exists('comment_alter_taxonomy')) {
-    db_query("DROP TABLE {comment_alter_taxonomy}");
   }

These comments should all be very easy to address. If you'd like you can wait to reroll until after #318302: Simplify again the comment insert logic gets committed, since I'll most likely commit that before branching for Drupal 6.

Again, thanks for getting this port started. We'll probably have to wait until the project_issue module is ported to D6 before we can finalize the D6 version of this module, but it would be great to get as much done now as we can.

subscribing

Since Simplify again the comment insert logic has been committed, should this get a reroll?

This is needed for the drupal.org upgrade.

A port of the comment_alter_taxonomy module for D6 is, in part, dependent on any changes to the project_issue module that might result from the port to D6. But we can certainly get a jump on porting of this module.

subscribing.

Any news on this ultimateboy?

Courtesy of the drupal.org upgrade sprint:

• Upgrade comment_alter_taxonomy to D6: http://drupal.org/cvs?commit=167096
• Experimental Views integration (the integration of project_issue itself will change soon, so this is *really* experimental): http://drupal.org/cvs?commit=167124

Marking as active (this needs testing).

subscribe, thanks

+1

Works for the Drupal.org upgrade.

Now released.