Extra code documentation of $base_url in settings.php
Alan D. - November 11, 2008 - 11:31
| Project: | Drupal |
| Version: | 6.x-dev |
| Component: | base system |
| Category: | task |
| Priority: | normal |
| Assigned: | sharda_ram |
| Status: | closed |
| Issue tags: | needs backport to D6, Novice, Quick fix |
Description
After getting some strange errors using update.php, I noticed that Drupal does not support relative $base_urls, such as '/drupal', etc. The patch adds a couple of invalid examples to help others from experiencing the same error.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| settings-d6-dev.patch | 1.19 KB | Idle | Passed: 10818 passes, 0 fails, 0 exceptions | View details | Re-test |
#1
Should be fixed in HEAD and optionally backported.
- * and fill in the URL to your Drupal installation.+ * and fill in the complete URL to your Drupal installation.
I would use "...the absolute URL..." instead as that's more common terminology. I would drop the "invalid examples" all-together: requiring an absolute URL and giving three absolute URLs as an example should be more than enough IMO.
#2
#3
Very first patch. Going by suggestions from mr.baileys, the only change needed is to change 'complete URL' to 'absolute URL'.
#4
At first glance it doesn't seem necessary given that the comments give a few example base_url's, all of which are absolute, but if you had problems then chances are others had them or will have them too. So that's reason enough for me.
Applies itself cleanly, solves a problem as simply as possible, obviously abides by coding standards (it only adds one word to the comments)...it has my vote.
#5
Committed to CVS HEAD. Thanks.
#6
Congrats on your first committed patch, sharda_ram (if that's what you meant by very first patch) :)
#7
It'll be much better next time, I promise :-) This one was just to get used to cvs and submitting patches, etc. Thanks for responding so quickly.
#8
Let's port to 6-x
#9
So here the 1 line patch
#10
Great, same one line documentation change in settings.php for D6 that Dries already committed to D7. It's fine and should be RTBC :)
#11
Thanks, committed to Drupal 6 too.
#12
Automatically closed -- issue fixed for 2 weeks with no activity.