Closed (fixed)
Project:
Drupal core
Version:
6.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
11 Nov 2008 at 11:31 UTC
Updated:
2 Jan 2014 at 23:45 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
mr.baileysShould be fixed in HEAD and optionally backported.
I would use "...the absolute URL..." instead as that's more common terminology. I would drop the "invalid examples" all-together: requiring an absolute URL and giving three absolute URLs as an example should be more than enough IMO.
Comment #2
sharda_ram commentedComment #3
sharda_ram commentedVery first patch. Going by suggestions from mr.baileys, the only change needed is to change 'complete URL' to 'absolute URL'.
Comment #4
mcrittenden commentedAt first glance it doesn't seem necessary given that the comments give a few example base_url's, all of which are absolute, but if you had problems then chances are others had them or will have them too. So that's reason enough for me.
Applies itself cleanly, solves a problem as simply as possible, obviously abides by coding standards (it only adds one word to the comments)...it has my vote.
Comment #5
dries commentedCommitted to CVS HEAD. Thanks.
Comment #6
mcrittenden commentedCongrats on your first committed patch, sharda_ram (if that's what you meant by very first patch) :)
Comment #7
sharda_ram commentedIt'll be much better next time, I promise :-) This one was just to get used to cvs and submitting patches, etc. Thanks for responding so quickly.
Comment #8
andypostLet's port to 6-x
Comment #9
andypostSo here the 1 line patch
Comment #10
burningdog commentedGreat, same one line documentation change in settings.php for D6 that Dries already committed to D7. It's fine and should be RTBC :)
Comment #11
gábor hojtsyThanks, committed to Drupal 6 too.