There is an extra logging statement that is being run that does not check the status of the db_maintenance_log configuration option.

watchdog('db_maintenance', 'Optimized @table table in @db database.', array('@db' => $db_name, '@table' => $table_name), WATCHDOG_DEBUG);

This can be completely removed because a few lines down there's another watchdog that does check this config option that logs the same information as a single message.

CommentFileSizeAuthor
#3 332918_watchdog.patch778 bytesdboulet
remove_duplicate_debug.patch544 bytesastoltz

Comments

deekayen’s picture

Version: 6.x-1.1 » 6.x-2.0-beta1
Status: Needs review » Fixed

Notice that line is at the debug level and the other one is at the info level. I wrapped the debug one in the same if statement as the other.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

dboulet’s picture

Version: 6.x-2.0-beta1 » 6.x-1.3
Status: Closed (fixed) » Needs review
StatusFileSize
new778 bytes

Can we get this fix backported to the 1.x branch, since that one is 'recommended'?

deekayen’s picture

Status: Needs review » Fixed

committed to 6.x-1.x

jvieille’s picture

How can we get this 6.x-1.x?

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

dboulet’s picture

Hi jvieille, you can try getting that branch through git:

http://drupal.org/node/41588/git-instructions/6.x-1.x

jvieille’s picture

I have no clue how I can get something there.
As the change is committed, why not releasing the 6.x-1.x version unless no testing will occur?

dboulet’s picture

jvieille, you can try applying the changes from #3 manually, they're pretty simple. The changes will be included in next update.

jvieille’s picture

The manual change is OK, but I wish not to keep this module hacked.
When this will be committed in a visible update?
What is this 6.x-1.x that is nowhere?

Thanks

jvieille’s picture

Please committ this
Thanks