Download & Extend

db_maintenance_log is not being honored

Project:DB Maintenance
Version:6.x-1.3
Component:Code
Category:bug report
Priority:minor
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

There is an extra logging statement that is being run that does not check the status of the db_maintenance_log configuration option.

watchdog('db_maintenance', 'Optimized @table table in @db database.', array('@db' => $db_name, '@table' => $table_name), WATCHDOG_DEBUG);

This can be completely removed because a few lines down there's another watchdog that does check this config option that logs the same information as a single message.

AttachmentSize
remove_duplicate_debug.patch544 bytes

Comments

#1

Version:6.x-1.1» 6.x-2.0-beta1
Status:needs review» fixed

Notice that line is at the debug level and the other one is at the info level. I wrapped the debug one in the same if statement as the other.

#2

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#3

Version:6.x-2.0-beta1» 6.x-1.3
Status:closed (fixed)» needs review

Can we get this fix backported to the 1.x branch, since that one is 'recommended'?

AttachmentSize
332918_watchdog.patch 778 bytes

#4

Status:needs review» fixed

committed to 6.x-1.x

#5

How can we get this 6.x-1.x?

#6

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#7

Hi jvieille, you can try getting that branch through git:

http://drupal.org/node/41588/git-instructions/6.x-1.x

#8

I have no clue how I can get something there.
As the change is committed, why not releasing the 6.x-1.x version unless no testing will occur?

#9

jvieille, you can try applying the changes from #3 manually, they're pretty simple. The changes will be included in next update.

#10

The manual change is OK, but I wish not to keep this module hacked.
When this will be committed in a visible update?
What is this 6.x-1.x that is nowhere?

Thanks

#11

Please committ this
Thanks

nobody click here