There is an extra logging statement that is being run that does not check the status of the db_maintenance_log configuration option.
watchdog('db_maintenance', 'Optimized @table table in @db database.', array('@db' => $db_name, '@table' => $table_name), WATCHDOG_DEBUG);
This can be completely removed because a few lines down there's another watchdog that does check this config option that logs the same information as a single message.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 332918_watchdog.patch | 778 bytes | dboulet |
| remove_duplicate_debug.patch | 544 bytes | astoltz |
Comments
Comment #1
deekayen commentedNotice that line is at the debug level and the other one is at the info level. I wrapped the debug one in the same if statement as the other.
Comment #3
dboulet commentedCan we get this fix backported to the 1.x branch, since that one is 'recommended'?
Comment #4
deekayen commentedcommitted to 6.x-1.x
Comment #5
jvieille commentedHow can we get this 6.x-1.x?
Comment #7
dboulet commentedHi jvieille, you can try getting that branch through git:
http://drupal.org/node/41588/git-instructions/6.x-1.x
Comment #8
jvieille commentedI have no clue how I can get something there.
As the change is committed, why not releasing the 6.x-1.x version unless no testing will occur?
Comment #9
dboulet commentedjvieille, you can try applying the changes from #3 manually, they're pretty simple. The changes will be included in next update.
Comment #10
jvieille commentedThe manual change is OK, but I wish not to keep this module hacked.
When this will be committed in a visible update?
What is this 6.x-1.x that is nowhere?
Thanks
Comment #11
jvieille commentedPlease committ this
Thanks