Hello,

I was confused for a while about the purpose of /feed aliases, such as for /node/1/feed. In pathauto settings, the user is shown this field title:
Internal feed alias text (leave blank to disable):
and this help text:
The text to use for aliases for RSS feeds. Examples are "feed" and "0/feed".

My confusion stemmed from my assumption that drupal, with default, clean configs, offers a feed for /node/1/feed. However it does not. One must install a module in order to get a feed at that address.

I would like to suggest that you add into the help text, something along these lines:

By default, /node/*/feed is an inactive address. To get a feed at such an address, you must install and configure a module such as commentrss or views.

I'm not sure what the exact best wording would be.

For reference, here is my post to the forum about this: http://drupal.org/node/332709

CommentFileSizeAuthor
#10 pathauto-n333002.patch1.06 KBdamienmckenna
#8 333002_no_node_feeds_default.patch760 bytesgreggles
#4 fix_feed_alias_descriptions_v1.patch1.39 KBao2
#1 fix_feed_alias_v0.patch1.73 KBao2
#5 fix_feed_alias_descriptions_v2.patch1.3 KBao2

Comments

ao2’s picture

ao2 commented
Title: add tip about /feed aliases. » add tip about /feed aliases, or fix the code?
Component: Documentation » Miscellaneous
Category: task » support
Status: Needs review » Active
StatusFileSize
new fix_feed_alias_v0.patch1.73 KB

Hi,

I understood it the other way around :), I though this setting was for the _alias_ created by pathauto not for the source feed path.
If this is really the case, then the code has a bug which I tried to fix in the attached patch.

But I am not sure of my interpretation either, drupal has a standard path for nodes node/$nid but not for feeds AFAIK, even if the /feed suffix is the most used one.

Maybe pathauto should provide a way to set both the source suffix and a replacement pattern for feeds; for now, for my use case, I would assume that feeds use all the /feed suffix usuring that in the feed creator (in my case it is the Views module) and I let pathauto rename them to /rss.xml.

Any comments?

Regards,
Antonio

UPDATE: please ignore the attached patch.

ao2’s picture

ao2 commented
Component: Documentation » Miscellaneous
Category: task » support

Sorry, I've just found the right issue #286843: Provide control over "feed" in url aliases which explains the situation, I am now convinced that I was wrong and also that the wording of this setting description should be improved :)
What about mentioning that the setting refers to the source path of the feed, and that it hardcodes the aliased path?

Sorry for the noise.

Regards,
Antonio

ao2’s picture

ao2 commented
Title: add tip about /feed aliases » add tip about /feed aliases.

Restoring Component and Category.

ao2’s picture

ao2 commented
Title: add tip about /feed aliases, or fix the code? » add tip about /feed aliases.
Component: Miscellaneous » Documentation
Category: support » task
Status: Active » Needs review
StatusFileSize
new fix_feed_alias_descriptions_v1.patch1.39 KB

What about the attached changes?

Regards,
Antonio

UPDATE: please ignore this patch.

ao2’s picture

ao2 commented
Component: Miscellaneous » Documentation
Category: support » task
Status: Active » Needs review
StatusFileSize
new fix_feed_alias_descriptions_v2.patch1.3 KB

Please use this one, v1 is against the wrong file.

Sorry,
Antonio

ao2’s picture

ao2 commented
Category: task » bug

Turning this into a documentation bug.

giorgio79’s picture

giorgio79 commented

Was also wondering what is the difference between "internal feed" and a plain feed output by views module for the taxonomy/term page?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
StatusFileSize
new 333002_no_node_feeds_default.patch760 bytes

Here's another point - we should just default the node feeds to off.

Also, we can't change strings in 6.x-1.x so I'm not committing the text change just yet...

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Committed that last patch to HEAD and 6.x-1.x

http://drupal.org/cvs?commit=276088
http://drupal.org/cvs?commit=276090

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new pathauto-n333002.patch1.06 KB

greggles: I think a key issue is that the help text is mistaken - the first example creates an invalid URL alias where it will try creating a path from e.g. "products/animals/feed" to "taxonomy/term/123/feed", which does not work using Drupal core, an additional layer like Views must be added to handle this situation.

I suggest changing it to something like the following:

Provide a value to generate aliases for the internal "taxonomy/term/%tid/%depth/feed" RSS feed paths. Drupal core requires an argument to control the depth followed by the string "feed" , e.g. "0/feed". The default "0/feed" will show only the content tagged with that specific term while "all/feed" will show all content from child terms. Removing the depth portion of the string could cause RSS feeds to stop working.

ao2’s picture

ao2 commented

In there anything wrong with the change proposed in #5?
Nobody commented on that.

Thanks,
Antonio

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

@ao2: #5 above left the existing wording untouched, which is what my patch was attempting to clear up. I also included working to help people understand what affect the field actually had.

ao2’s picture

ao2 commented

@DamienMcKenna: when I read Provide a value to generate aliases... my mind believes that this is a value pathauto is going to put into the aliases it generates, while TBOMK it is not, it is the value used in the "source" (not aliased) path as set by drupal core (feed, rss.xml, etc.).

Also Drupal does not _require_ the depth to be specified explicitly, if you omit the depth, 0 is taken.

The last part of your description is OK tho, I just think that the first part could be improved a bit, and maybe the title too.
I am sure you will do better than me, I am not a native English speaker and my description was maybe too much schematic.

Thanks,
Antonio

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Component: Documentation » User interface

Status: Needs review » Needs work

The last submitted patch, pathauto-n333002.patch, failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 7.x-1.x-dev » 6.x-1.x-dev

Feed aliases no longer supported in 6.x-2.x/7.x-1.x.

  • greggles committed 6735177 on 8.x-1.x 
    task #333002 by greggles: don't add a feed aliases to nodes by default

  • greggles committed 6735177 on 8.x-1.x 
    task #333002 by greggles: don't add a feed aliases to nodes by default
mably’s picture

mably commented
Issue summary: View changes
Status: Needs work » Closed (outdated)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.