The views UI is altered by the navigate module. Basically the tabbing is removed from the views module. The module appears to still work properly, however, the altered UI could cause a lot of annoying scrolling. See attached for screenshot.

CommentFileSizeAuthor
screenshot.gif55.53 KBtheabacus

Comments

redndahead’s picture

redndahead commented

I have debugged this down to the inclusion of jquery-ui.js. Debugging after that is going to be interesting. This may be a views issue, but not quite sure.

redndahead’s picture

redndahead commented

Looking at the views code it's using jquery UI tabs, without using the full jquery ui. It checks to see if jquery-ui already exists and if it does it uses it if not it uses it's own implementation. My guess is it sees the jquery-ui provided by navigate and tries to implement it's tab functionality. Either it doesn't exist or it isn't implemented the way views is using it.

My suggestion would be instead of implementing your own jquery-ui you make http://drupal.org/project/jquery_ui a dependency of navigate. The jquery_ui module is maintained by quicksketch and it seems to stay updated often so I would feel comfortable with it. If there are still issues while using jquery_ui then I would file a bug with views to see it fixed.

It may be better to start being dependent on another jquery-ui implementation as there is a push to get jquery-ui included in core in D7.

Thoughts?

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Status: Active » Needs review

I enabled the jquery_ui module, and changed 1 line in navigate_init() function. Both modules (views and navigate) seems to work correctly..

-    drupal_add_js(drupal_get_path('module', 'navigate') .'/jquery_plugins/jquery-ui.js', 'module', 'footer');
+    jquery_ui_add('jquery.ui.all');

but I guess not all jquery.ui functions are needed by the navigate module..

chrisshattuck’s picture

chrisshattuck commented

Nice legwork guys. It doesn't look like views is using the ui module, and I would rather not require another dependency, so for now, I should be able to check for views and if it exists, hold off on including Navigate's version of UI. I like the idea of ui module, though, and will consider using it in the future.

chrisshattuck’s picture

chrisshattuck commented
Status: Needs review » Fixed

Sorry it took so long to get to this, but it has finally been fixed in Beta5.

The way I fixed it was adding the Tabs to the Navigate custom jquery.ui. However, I also do a check to see if the jquery_ui module is installed. If it is, it uses the code in #3 above.

Thanks again for narrowing this down! Cheeers!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.