Redundant text - "Profile Module Installed"
| Project: | User registration notification |
| Version: | 5.x-1.8 |
| Component: | User interface |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Reporting "Profile Module Installed" before displaying the profile fields feels a little redundant - of course the module is installed if there are fields being displayed. Conversely, there's no text displayed if somebody's used the !profile token and profile module is not installed (admittedly I can't see why anyone would use the !profile token without switching the profile module on, but if I did, I know I'd like to be told). I'd like to see this refined a little to give more appropriate feedback as follows:
IF the module is not installed - $profile_data = 'Profile Module not installed.';
IF the module is installed but no fields are defined - $profile_data = 'No profile fields defined.';
IF the module is installed and fields are defined - $profile_data = [the fields and their values as currently.]
I've already tweaked my local install to cater for the first and last cases (commented out line 85 and added after line 105:
<?php
} else {
$profile_data = 'Profile Module not installed.';
?>
#1
Yea that is debugging code I left in by mistake. Again your idea makes a lot of since. I wonder if this is a good time for a new release?
Thanks
Robert
#2
Was committed with another patch. It will be in 1.9 release.
Thanks
Robert
#3
Automatically closed -- issue fixed for two weeks with no activity.