chx wrote a SchemaAPI unit test in #302399: Schema API is not unit tested which revealed that MySQL schema API doesn't handle NULL default values correctly. Here is a fix for that. The test for that is in the original issue :)

CommentFileSizeAuthor
fix-mysql-schema.patch1.14 KBdamien tournoud

Comments

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

Nice piece...

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs review

I would like to see Crell review this patch, please.

Crell’s picture

Crell commented

The approach seems sane. I've not tried running it yet, but I assume chx did. :-) Looks good to me if it works.

damien tournoud’s picture

damien tournoud commented
Status: Needs review » Reviewed & tested by the community

Per #3.

I ran that patch thru the new Schema API test in #302399: Schema API is not unit tested. That test fails before the patch, and succeeds after. No other impact on the tests.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. It doesn't seem to fix all tests though.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.