It looks like the DRUPAL-6 tag was moved to the wrong version at one point. This problem only shows up for people downloading from CVS, because the Drupal packaging script adds it automatically.

CommentFileSizeAuthor
#4 Modules without the patch.png24.68 KBBevan
#4 Modules with the patch.png24.05 KBBevan
#2 333732.patch474 bytesBevan

Comments

moshe weitzman’s picture

moshe weitzman commented

Indeed. The missing line from mollom.info is

core = 6.x

Bevan’s picture

Bevan commented
StatusFileSize
new 333732.patch474 bytes

Standard patch attached

I marked #336423 http://drupal.org/node/336423 duplicate.

dries’s picture

dries commented 
deimos:mollom-6 dries$ cvs status mollom.info 
===================================================================
File: mollom.info      	Status: Up-to-date

   Working revision:	1.2.2.1
   Repository revision:	1.2.2.1	/cvs/drupal-contrib/contributions/modules/mollom/mollom.info,v
   Commit Identifier:	767a47f243aa4567
   Sticky Tag:		DRUPAL-6--1 (branch: 1.2.2)
   Sticky Date:		(none)
   Sticky Options:	(none)

That looks good to me, not? Are you guys using the DRUPAL-6--1 branch?

Bevan’s picture

Bevan commented
StatusFileSize
new Modules with the patch.png24.05 KB
new Modules without the patch.png24.68 KB

I'm not sure that we have clearly communicated the bug. When you get mollom with cvs co ... -r DRUPAL-1--6 ..., the module can not be enabled. See the first screenshot.

After applying patch in comment 2, the module can be enabled. See the second screenshot. This is not an issue with drupal.org packaged tarballs because the packager adds lines to *.info files that mean this line is not required in CVS. Nevertheless it should still be there.

This appears to only be an issue with DRUPAL-6--1-6 and not with DRUPAL-6--1-5 or DRUPAL-6--1. See also screenshots on http://drupal.org/node/336423#comment-1119551

dries’s picture

dries commented

I understand the bug, but it is not clear how to fix it. As far as I can see, the only solution is to make a new release.

moshe weitzman’s picture

moshe weitzman commented

Yes, you have to make a new release. A release cannot be changed once created.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Reviewed & tested by the community » Closed (won't fix)

Mollom 6.x-1.7 and latest DRUPAL-6--1 CVS both now have the appropriate core = 6.x in mollom.info. Without deleting the 6.x-1.6 release and recreating it, there's nothing that can be done to fix that release, so I'm going to set this as "won't fix". Please upgrade to the latest version.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Closed (won't fix) » Fixed

I guess fixed is the most appropriate. :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.