Closed (fixed)
Project:
Goofy
Version:
6.x-2.x-dev
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Reporter:
Created:
13 Nov 2008 at 08:50 UTC
Updated:
21 Apr 2009 at 20:40 UTC
The lang and xml:lang attributes in version 1.22.4.1 are empty, which is not valid.
Comments
Comment #1
fgmAnd other validation errors in the 6.2 version too: it is mostly XHTML but with a HTML4.01 doctype and some all new nesting errors.
Comment #2
fgmToday's version now validates as XHTML 1.0 Strict. Tested on home page, page, story, and book node page, with and without comments.
Comment #3
fgmActually only fixed in the 6.2.x branch.
Comment #5
peterx commentedThe language attributes are missing from the 2008-Dec-29 download as documented at http://d-theme.com/goofy. Is there an updated version on the way?
Comment #6
fgmFixed in today's version: W3 validation passes on the pages I've tested.
It would have been faster if someone had opened an issue about it here on d.o., instead of complaining on a third party site, though.
Comment #7
peterx commentedHello fmg, if the "third party site" is D theme, D theme provides prospective theme users the validation buttons already set up and, where a theme is close to validation, advice on how to update the theme. All the research conducted at D theme is reported back to theme developers at drupal.org so the developers can update their themes.
Developers sometimes update their CVS version but not publish an official update. D theme visitors are not CVS users and get to choose between the recommended theme versions on drupal.org, if there is a recommended version. D theme checks for official updates daily, just as a site owner are encouraged to to when using the Drupal administration pages. D theme looks forward to your update going through the drupal.org theme update process.
The people selecting themes at D theme have requirements to reach certain targets, XHTML 1.0 Strict, WCAG A, etc. Some developers choose to not aim for those targets because their themes are used on sites visited by old browsers. Fine. D theme is happy to explain the aim of a theme where the theme is not designed to pass one of those validations.
D theme is there for site owners who will never use CVS and do not log into drupal.org because they want to use their Web site, not develop it. It gives them enough information to decide if a theme is ready for their site and how long a contractor might take to install a them. Consider the site a free testing service now and a demonstration site once the XHTML 1.0 Strict validation errors are removed.
Comment #8
fgmPeterx: you seem to imply that
- you are the d-theme maintainer
- you (or whoever is the d-theme maintainer) "reported back to [me] at drupal.org".
Under these assumptions:
- unless you consider the current thread as being this reporting, I did not receive a report from d-theme; and d-theme contains additional information which was not carried back in this issue, such as the (IMO ill-advised) comment about screenshots.
- the wording on d-theme make it look as if I hadn't been maintaining the theme, with a question "Where do you start repairing the theme? ", for which, of course, there is no way to answer on d-theme since comments are not opened, and even no way to contact the site maintainer, since the site contact form is not enabled and the site maintainer does not link to his d.o. profile.
Actually, as you can see, I fixed the problem as soon as I received the d.o. update, slightly over 1 day after you posted it. But, unless you happen to be this hidden maintainer, I still don't have a way to make it known on d-theme, leaving me painted in false light until the d-theme information is updated.
More constructively, can you address the CNR status on this issue in case you find remaining problems ?
Comment #9
peterx commentedDownload from Feb 22.
<table class="goofy-node goofyo sticky-enabled" zebra="" cellpadding="0" cellspacing="0">Comment #10
fgmGood ! Fix applied.
Comment #11
fgm