imagecache_preset needs auto increment?

Yep, same problem here. Too bad I decided it was my old d5.x presets before noticing/checking the issue queue (And deleting them all). Good call marcvangend!

I can switch up the table, but unfortunately this leaves our less advanced brethren out of the loop (Not to mention, it might very well be a nasty hack, as I recall drupal was supposed to handle auto-increments through the database abstraction layer because of shoddy support for auto-increment in DB systems other than mysql)

Suggestions anyone?

You can re-implement the primary keys (which will receive the auto increment property) with the following snippet in imagecache.install using the Schema API.

<?php
imagecache_update_5() {
  $ret = array();
  
  // Rebuild the primary key to enable auto-increment
  $schema = imagecache_schema();

  db_drop_primary_key($ret, 'imagecache_preset');
  db_change_field($ret, 'imagecache_preset', 'presetid', 'presetid', $schema['imagecache_preset']['fields']['presetid'], array('primary key' => $schema['imagecache_preset']['primary key']));
  
  db_drop_primary_key($ret, 'imagecache_action');
  db_change_field($ret, 'imagecache_action', 'actionid', 'actionid', $schema['imagecache_action']['fields']['actionid'], array('primary key' => $schema['imagecache_action']['primary key']));
  
  return $ret;
}
?>

@yhahn: can you post as a patch?

Read the docs for hook_update_N, you can't reference the schema in an update. Think about it for a minute... what happens after you update the schema and someone goes to run this update... assumptions you're making about the schema will no longer be true.

totally untested but here's the correct way to do this.

see #304376: Update function from 5.x -> 6.x