I have the active column's in all of my tables on Drupal themed to have a darker shade. It always switches to whichever column is being sorted. There doesn't seem to be an 'active' class in the advanced forum module though. Is there any easy fix for this?

CommentFileSizeAuthor
#4 topic-list-detail.gif16.31 KBdbirider

Comments

michelle’s picture

Status: Active » Postponed (maintainer needs more info)

Where? The only place I can think of that has any table sorting is the topic list and that has an active class on it. Tablesorting comes right from core.

Michelle

dbirider’s picture

Status: Postponed (maintainer needs more info) » Active

Here's an example of what I mean, from your demo site:

http://socnet.shellmultimedia.com/views/users_points - this active column is themed with a #ddd background.
http://socnet.shellmultimedia.com/forum/3 - Active topic list columns aren't themed and don't appear to be themable

michelle’s picture

Status: Active » Postponed (maintainer needs more info)

Sure they are...

Go to: http://socnet.shellmultimedia.com/forum/3?sort=asc&order=Replies
Then inspect the "Replies" with firebug and you get:

<a class="active" title="sort by Replies" href="/forum/3?sort=desc&amp;order=Replies">Replies<img height="13" width="13" title="sort descending" alt="sort icon" src="/misc/arrow-desc.png"/></a>

That's right out of core forum there. Only thing AF does is add a views column. That's not sortable because of the way the tablesorts work.

So I still am not seeing a problem.

Michelle

dbirider’s picture

Status: Postponed (maintainer needs more info) » Active
StatusFileSize
new16.31 KB

Hi Michelle,

Sorry I should have been more specific. The part you are refering to works fine for me :)

I attached an image showing exactly what I'm referring to. All of the tables on Drupal theme the entire active column like this, even the default drupal forum. With advanced forum installed though this feature goes away.

michelle’s picture

Category: feature » bug

Hmm... It should have the same classes as core forum. If it doesn't, this is a bug. I'll look into it.

Michelle

transliteration’s picture

I confirm , that I am observing the same behavior in my forum, it will bee great to fix that issue.

michelle’s picture

Title: Theming the 'active' topic list column » Tableheader loses active class when adding views column
Version: 5.x-1.0-alpha13 » 5.x-1.x-dev
Component: Styles » Code

Ah, I think I see the problem. I'm recreating the table headers to add in the views column and that is probably wiping it out. Fixing this will take some research because I haven't the foggiest idea how to do it at the moment. Unless someone provides a patch, this probably won't be fixed for a while.

Michelle

michelle’s picture

Category: bug » feature
Status: Active » Closed (won't fix)

Ok, I've just spent the last 45 minutes digging into this and redoing how I do the tableheaders only to realize that there isn't actually a bug in them after all. The problem here is that core forum in D6 doesn't have this feature and AF uses D6's core forum backported.

I don't see any easy way of making this happen. I would have to capture the column that is being sorted on while building the table header and then pass it on down through all the way to the template. It's doable but messy and not something I'm interested in putting time in since I always hated the look of that anyway. If someone wants to write a patch, I'll consider it if it doesn't make the code too horrid.

Michelle

michelle’s picture

Also, if this is really important to someone, it should be filed as an issue on core forum.

Michelle