Node source radios should be required
ugerhard - November 14, 2008 - 11:15
| Project: | Nodecarousel |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Description
I had set up a node carousel was wondering why it just wouldn't work. After some debuggung if found out that I had select a view to use as a node source, but not checked the Node source radios. As this value seems to be absolute required for NC to work, the node source radio buttons form element should be required, too, i.e.
<?php
$form['node-source']['node_source'] = array(
'#type' => 'radios',
'#title' => t('Node Source'),
'#default_value' => $node_carousel->node_source,
'#options' => $sources,
'#required' => true,
);
?>instead of
<?php
$form['node-source']['node_source'] = array(
'#type' => 'radios',
'#title' => t('Node Source'),
'#default_value' => $node_carousel->node_source,
'#options' => $sources,
);
?>in line 443 of nodecarousel.module
Incidentally, there's a #required property set for the containing fieldset $form['node-source'] in line 421, but this does not seem to have any effect.