This seems like an interesting module. From my initial review it seems like this module is useful:

0) You are building or modifing a form using Drupal's form API (you mention this point already on the project page so it's #0)
and
1) If you need uploads and want something like the core upload field
2) You aren't using cck or don't want to
3) The core upload field is being used for something else OR you aren't on a node form

Is that right? If so, I think the project page should have that information added. It is currently a little confusing when/where people might want to use it.

Also, the use of "field" in the title makes it seem like a cck field, but it isn't (is it?). I think you should clarify that http://drupal.org/project/filefield provides similar functionality for CCK and that this module is not for CCK but just for direct FAPI coding.

Comments

rszrama’s picture

+1 - seems like these would more correctly be called elements instead of fields, given that hook_elements() is used to define new FAPI #types.

alan d.’s picture

Assigned: Unassigned » alan d.

Thanks for the fast feedback :)

I've updated the project page a bit to clarify the reasons for it's usage.

It is a good point to the naming, as it could cause confusion. I'll look to see if it is possible to rename the project to upload_element instead.

Tomorrow I plan to add better documentation, with a couple of examples. The code still needs a review for translation support.

alan d.’s picture

Version: » 6.x-1.x-dev
Status: Active » Closed (fixed)
alan d.’s picture

Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.