Closed (won't fix)
Project:
Views Saved Searches
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
14 Nov 2008 at 17:57 UTC
Updated:
5 Aug 2009 at 16:18 UTC
This function appears to be missing a parameter in the true-case of the 'if', where upon updating, the filters were not actually passed. See below:
function views_savedsearches_save($saved_search) {
if ($saved_search->sid && $saved_search->sid != 'new') {
db_query("UPDATE {views_savedsearches} SET uid = %d, vid = %d, name = '%s', filters = '%s' WHERE sid = %d",
$saved_search->uid,
$saved_search->vid,
$saved_search->name,
$saved_search->filters, // <== missing parameter
$saved_search->sid
);
}
else {
$saved_search->sid = db_next_id("{views_savedsearches}_sid");
db_query("INSERT INTO {views_savedsearches} (sid, uid, vid, name, filters) VALUES(%d, %d, %d, '%s', '%s')",
$saved_search->sid,
$saved_search->uid,
$saved_search->vid,
$saved_search->name,
$saved_search->filters
);
}
return $saved_search->sid;
}
Comments
Comment #1
sdsheridanAlso a problem in the dev version.
Comment #2
wim leersUnfortunately, I don't have the time anymore to work on this module. So until you can provide a patch, I'm marking this as won't fix.