Posted by open-keywords on November 14, 2008 at 10:54pm
Jump to:
| Project: | Signwriter |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Agileware |
| Status: | closed (fixed) |
Issue Summary
Hi
Thanks for this very useful and well documented module.
However, I have faced a few trouble when using the input filter feature:
- the label to enter the pattern is "Shadow Colour" instead of "Input Filter Pattern"
- the sample pattern given for h1 isn't consistent with the one for h* and leads to content being truncated after the first occurrence of h1
- preg_replace and the 'e' modifier may escape quotes, then the image being generated contains backslashes when the text contained
- some patterns could be made case insensitive
- quotes in text are meaningful and shouldn't be ignored
Please find below a comprehensive patch for all these issues (the main one being related to backslashes and to the h1 pattern)
Regards
| Attachment | Size |
|---|---|
| signwriterescapesdev.patch | 3.37 KB |
Comments
#1
Thanks for the patch. I've tested against D5 version and looks OK. Trying to apply the same changes to D6 with mixed results, which is expected. So just working thru those.
#2
This has been applied to the 5.x-1.x-dev version.
Changing to the 6 branch as it has not been applied there yet.
#3
Changing to 6.x-2.x version.
These changes are already done / no longer required in the newest version.
#4
Automatically closed -- issue fixed for 2 weeks with no activity.