Posted by Dave Reid on November 15, 2008 at 2:10am
Jump to:
| Project: | Gravatar integration |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Dave Reid |
| Status: | closed (fixed) |
Issue Summary
I propose that the "Image size" option in the Gravatar settings is unnecessary. We already have the 'user_picture_dimensions' variable which we should use instead of duplicating an option. The following code
would return a $size parameter, no larger than 512px (the maximum allowed by the gravatar service):
<?php
$size = min(explode('x', variable_get('user_picture_dimensions', '85x85')), 512);
?>
Comments
#1
I vote for: settings will be more simple and logic.
#2
For now I have added a default option for the size setting to use the existing user picture dimensions, looking at options for removal.
#3
Have removed the gravatar_size variable from 6.x-1.x. Will be a change in the next release.
#4
Automatically closed -- issue fixed for two weeks with no activity.