Closed (fixed)
Project:
Tell A Friend Node
Version:
6.x-1.2
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
15 Nov 2008 at 04:11 UTC
Updated:
28 Nov 2008 at 06:10 UTC
This module has an option to import addresses from plaxo, whatever that is, and it says the option can be disabled, but that setting is not saved. It looks like the field was left out of the insert and update queries by mistake. Here's a corrected version from tellafriend_node.module, lines 75 on:
function tellafriend_node_insert($node) {
db_query("INSERT INTO {tellafriend_node_data} (
nid,
tellafriend_node_max_allowed_recipients,
tellafriend_node_include_plaxo, -- added this line
tellafriend_node_subject,
tellafriend_node_subject_is_editable,
tellafriend_node_message,
tellafriend_node_message_is_editable,
tellafriend_node_message_constant_text,
tellafriend_node_show_opt_in,
tellafriend_node_opt_in_text,
tellafriend_node_show_opt_out,
tellafriend_node_opt_out_text,
tellafriend_node_first_name_is_required,
tellafriend_node_last_name_is_required,
tellafriend_node_thank_you_page
)
VALUES (
%d,
%d,
%d, -- and this...
'%s',
%d,
'%s',
%d,
'%s',
%d,
'%s',
%d,
'%s',
%d,
%d,
'%s'
)",
$node->nid,
$node->tellafriend_node_max_allowed_recipients,
$node->tellafriend_node_include_plaxo, // added this...
$node->tellafriend_node_subject,
$node->tellafriend_node_subject_is_editable,
$node->tellafriend_node_message,
$node->tellafriend_node_message_is_editable,
$node->tellafriend_node_message_constant_text,
$node->tellafriend_node_show_opt_in,
$node->tellafriend_node_opt_in_text,
$node->tellafriend_node_show_opt_out,
$node->tellafriend_node_opt_out_text,
$node->tellafriend_node_first_name_is_required,
$node->tellafriend_node_last_name_is_required,
$node->tellafriend_node_thank_you_page
);
}
function tellafriend_node_update($node) {
db_query("UPDATE {tellafriend_node_data} SET
tellafriend_node_max_allowed_recipients = %d,
tellafriend_node_include_plaxo = %d, -- and this...
tellafriend_node_subject = '%s',
tellafriend_node_subject_is_editable = %d,
tellafriend_node_message = '%s',
tellafriend_node_message_is_editable = %d,
tellafriend_node_message_constant_text = '%s',
tellafriend_node_show_opt_in = %d,
tellafriend_node_opt_in_text = '%s',
tellafriend_node_show_opt_out = %d,
tellafriend_node_opt_out_text = '%s',
tellafriend_node_first_name_is_required = %d,
tellafriend_node_last_name_is_required = %d,
tellafriend_node_thank_you_page = '%s'
WHERE nid = %d",
$node->tellafriend_node_max_allowed_recipients,
$node->tellafriend_node_include_plaxo, // and this.
$node->tellafriend_node_subject,
$node->tellafriend_node_subject_is_editable,
$node->tellafriend_node_message,
$node->tellafriend_node_message_is_editable,
$node->tellafriend_node_message_constant_text,
$node->tellafriend_node_show_opt_in,
$node->tellafriend_node_opt_in_text,
$node->tellafriend_node_show_opt_out,
$node->tellafriend_node_opt_out_text,
$node->tellafriend_node_first_name_is_required,
$node->tellafriend_node_last_name_is_required,
$node->tellafriend_node_thank_you_page,
$node->nid
);
}
Comments
Comment #1
ggaetz commentedThanks for pointing this out. I've fixed it and the v1.3 release contains the fix.
Comment #2
ggaetz commented