The JavaScript contained in the tar file didn't work when some items in the basket were of a value >= 0.01
A variable referenced in the uc_free_order.js file was never set uc_free_order_next_method, causing the AJAX call back to fail.
How this ever worked for others I do not know?! Thus marking as critical...
Without this variable being populated it caused the payment details pane to be filled with a copy of the checkout page - which re cursed until FireFox stopped it. This was due to the AJAX call get_payment_details('cart/checkout/payment_details/' + uc_free_order_next_method); which never had a payment method on the end so failed.
Attached is my amended function with some new JQuery to find the first available payment method and select that.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | nextmethod.patch | 1.58 KB | budda |
| uc_free_order.js_.txt | 1.96 KB | budda |
Comments
Comment #1
rszrama commentedAny way I can get you to post this as a diff/patch so I can easily see what changed?
Comment #2
buddaPatch attached
Comment #3
hedgefrog commentedcould someone please update and advise whether we need this patch or not?
As far as I can tell from my testing, it seems to be working ok for me without the patch but I'm worried about whether something will go wrong with it for my customers.
Comment #4
rszrama commentedI had to tweak this patch, b/c it didn't take into account the order of the payment methods. See the D6 migration issue for more info.