The original SimpleTest package contains the functions assertWithinMargin() and assertOutsideMargin(). Both of these are very handy when you are working with floating point numbers that cannot be compared for equality (because of numerical errors).

I am attaching a patch that adds these two functions to the DrupalTestCase.

Also, can these be easily merged into Drupal 7?

CommentFileSizeAuthor
#19 334950-simpletest-margin.patch4.91 KBklausi
#17 issue-334950.patch5.31 KBarianek
#14 issue-334950.patch5.38 KBlilou
#10 334950-assert-margin.patch5.12 KBboombatower
#6 issue-334950-6.patch2.73 KBlilou
drupal_web_test_case.margin-tests.patch2.68 KBztyx

Comments

ztyx’s picture

ztyx commented

Oh, I meant DrupalWebTestCase of course...

boombatower’s picture

boombatower commented
Project: SimpleTest » Drupal core
Version: 6.x-2.5 » 7.x-dev
Component: Code » simpletest.module
Status: Active » Needs review

This should be done in D7 and then backported.

Status: Needs review » Needs work

The last submitted patch failed testing.

lilou’s picture

lilou commented
Status: Needs work » Needs review

See: #335122: Test clean HEAD after every commit and http://pastebin.ca/1258476

Status: Needs review » Needs work

The last submitted patch failed testing.

lilou’s picture

lilou commented
Status: Needs work » Needs review
StatusFileSize
new issue-334950-6.patch2.73 KB

Reroll from root directory.

catch’s picture

catch
he/him
Primary language English
commented

Are there existing use cases for these in core? Would be nice to use them if possible.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Needs work

I think we should have some basic tests for these in simpletest.test

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Issue tags: +Needs tests
boombatower’s picture

boombatower commented
Title: assertWithinMargin() and assertOutsideMargin() » SimpleTest:assertWithinMargin() and assertOutsideMargin()
Assigned: Unassigned » boombatower
Status: Needs work » Needs review
StatusFileSize
new 334950-assert-margin.patch5.12 KB
  • More detailed default messages.
  • Changed _assert() to assert().
  • Added test as requested.

In the future I will work on a cleaner/scalable way to test all the DrupalWebTestCase assertions.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Looks good.

dries’s picture

dries commented

I agree that it would be good to have some use cases in core. Can't think of any.

Status: Reviewed & tested by the community » Needs work

The last submitted patch failed testing.

lilou’s picture

lilou commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new issue-334950.patch5.38 KB

Reroll from HEAD.

Back to previous status.

Status: Reviewed & tested by the community » Needs work

The last submitted patch failed testing.

boombatower’s picture

boombatower commented
Status: Needs work » Needs review

teh bot?

arianek’s picture

arianek commented
StatusFileSize
new issue-334950.patch5.31 KB

applied patch to D7 HEAD:
Hunk #1 succeeded at 336 (offset 40 lines).

re-rolled for bot.

Status: Needs review » Needs work

The last submitted patch failed testing.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Assigned: boombatower » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 334950-simpletest-margin.patch4.91 KB

Reroll.

Status: Needs review » Needs work
Issue tags: -Needs tests

The last submitted patch, 334950-simpletest-margin.patch, failed testing.

Issue tags: +Needs tests

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.