How come some of the assert methods in the DrupalWebTestCase are protected and some are not? Are there any assert methods that should be public?

Comments

boombatower’s picture

boombatower commented
Project: SimpleTest » Drupal core
Version: 6.x-2.5 » 7.x-dev
Component: Code » simpletest.module
Category: support » task

This is just somewhat a slopping OO code that was brought up from PHP 4 and partially implemented scope modifiers.

This needs to be decided in core and backported.

boombatower’s picture

boombatower commented
Title: protected vs. public asserts » SimpleTest: Clean up OO scope modifiers
boombatower’s picture

boombatower commented
Project: Drupal core » SimpleTest
Version: 7.x-dev » 6.x-2.x-dev
Component: simpletest.module » Code
Assigned: Unassigned » boombatower
Status: Active » Patch (to be ported)

This has since been fixed.

boombatower’s picture

boombatower commented

#338239: Cleaning-up DrupalWebTestCase: pass #1

boombatower’s picture

boombatower commented
Status: Patch (to be ported) » Fixed

Complete backport of Drupal 7.x SimpleTest module. (voids all backports). (SimpleTest 2.6)

Please re-open if still an issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.